From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracing: Show the tracer options in boot-time created instance
Date: Wed, 19 Nov 2025 17:31:37 +0900 [thread overview]
Message-ID: <20251119173137.c7e489c079e942eedd48b249@kernel.org> (raw)
In-Reply-To: <20251119133942.df3ee2c01ccd40055cf139a4@kernel.org>
On Wed, 19 Nov 2025 13:39:42 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 8ae95800592d..4a6784057855 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -10231,11 +10231,16 @@ static __init int __update_tracer_options(struct trace_array *tr)
> > return ret;
> > }
> >
> > -static __init void update_tracer_options(struct trace_array *tr)
> > +static __init void update_tracer_options(void)
> > {
> > + struct trace_array *tr;
> > +
> > guard(mutex)(&trace_types_lock);
> > +
> > + list_for_each_entry(tr, &ftrace_trace_arrays, list)
> > + __update_tracer_options(tr);
> > +
> > tracer_options_updated = true;
Oops, I misunderstood this flag. This should be set *before* calling
__update_tracer_options(). Not updated.
Thanks,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2025-11-19 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 0:21 [PATCH v2] tracing: Show the tracer options in boot-time created instance Masami Hiramatsu (Google)
2025-11-19 4:39 ` Masami Hiramatsu
2025-11-19 8:31 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119173137.c7e489c079e942eedd48b249@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).