Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Donglin Peng <dolinux.peng@gmail.com>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Donglin Peng <pengdonglin@xiaomi.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH v7] function_graph: Enable funcgraph-args and funcgraph-retaddr to work simultaneously
Date: Mon, 24 Nov 2025 16:47:01 -0500	[thread overview]
Message-ID: <20251124164701.1216a073@gandalf.local.home> (raw)
In-Reply-To: <20251114025522.2115359-1-dolinux.peng@gmail.com>

On Fri, 14 Nov 2025 10:55:22 +0800
Donglin Peng <dolinux.peng@gmail.com> wrote:

> --- a/kernel/trace/trace_entries.h
> +++ b/kernel/trace/trace_entries.h
> @@ -95,14 +95,14 @@ FTRACE_ENTRY_PACKED(fgraph_retaddr_entry, fgraph_retaddr_ent_entry,
>  	TRACE_GRAPH_RETADDR_ENT,
>  
>  	F_STRUCT(
> -		__field_struct(	struct fgraph_retaddr_ent,	graph_ent	)
> +		__field_struct(	struct ftrace_graph_ent,	graph_ent	)
>  		__field_packed(	unsigned long,	graph_ent,	func		)
>  		__field_packed(	unsigned int,	graph_ent,	depth		)
> -		__field_packed(	unsigned long,	graph_ent,	retaddr		)

You can't delete the retaddr without breaking user space.

Please keep that here.

Thanks,

-- Steve

> +		__dynamic_array(unsigned long,	args				)
>  	),
>  
>  	F_printk("--> %ps (%u) <- %ps", (void *)__entry->func, __entry->depth,
> -		(void *)__entry->retaddr)
> +		(void *)__entry->args[0])
>  );
>  

  reply	other threads:[~2025-11-24 21:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14  2:55 [PATCH v7] function_graph: Enable funcgraph-args and funcgraph-retaddr to work simultaneously Donglin Peng
2025-11-24 21:47 ` Steven Rostedt [this message]
2025-11-24 21:49   ` Steven Rostedt
2025-11-24 21:54   ` Steven Rostedt
2025-11-25  1:12     ` Steven Rostedt
2025-11-25  2:05       ` Donglin Peng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251124164701.1216a073@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=dolinux.peng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=pengdonglin@xiaomi.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox