From: Steven Rostedt <rostedt@goodmis.org>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: Nam Cao <namcao@linutronix.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rv: Convert to use lock guard
Date: Wed, 26 Nov 2025 10:42:10 -0500 [thread overview]
Message-ID: <20251126104210.5696dbe9@gandalf.local.home> (raw)
In-Reply-To: <2803da35e4de12ef2ca966a69052bf228f1cd10f.camel@redhat.com>
On Wed, 26 Nov 2025 10:33:51 +0100
Gabriele Monaco <gmonaco@redhat.com> wrote:
> > > No biggy, but I wonder if this would look better as:
> > >
> > > return retval ? : count;
> >
> > Unless you really prefer it this way, I would rather not. The first time
> > I saw this syntax, it confused the hell out of me. Took me some time
> > scratching my head until I figured out that it is a GNU extension.
> >
> > I prefer to stay with the C standard unless there is major benefit not
> > to.
>
> To be fair, I find it a bit obscure as well, although it's frequently used
> within the kernel.
>
> Let's not change it then.
As I said, "No biggy". I personally like that notation better. But that's
my own personal choice. I won't push that on other ;-)
-- Steve
next prev parent reply other threads:[~2025-11-26 15:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 9:06 [PATCH v2 0/2] rv: Tidy up with auto-cleanup Nam Cao
2025-11-17 9:06 ` [PATCH v2 1/2] rv: Convert to use lock guard Nam Cao
2025-11-25 19:57 ` Steven Rostedt
2025-11-26 7:27 ` Gabriele Monaco
2025-11-26 8:36 ` Nam Cao
2025-11-26 9:33 ` Gabriele Monaco
2025-11-26 15:42 ` Steven Rostedt [this message]
2025-11-26 14:51 ` Steven Rostedt
2025-11-26 15:22 ` Gabriele Monaco
2025-12-01 15:24 ` Steven Rostedt
2025-12-01 15:28 ` Gabriele Monaco
2025-12-02 1:38 ` Steven Rostedt
2025-12-02 1:51 ` Steven Rostedt
2025-12-02 6:41 ` Gabriele Monaco
2025-12-01 15:28 ` Nam Cao
2025-11-17 9:06 ` [PATCH v2 2/2] rv: Convert to use __free Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126104210.5696dbe9@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namcao@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).