From: "Michal Koutný" <mkoutny@suse.com>
To: linux-block@vger.kernel.org, bpf@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
coreteam@netfilter.org, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Cc: "Michal Koutný" <mkoutny@suse.com>, "Hao Luo" <haoluo@google.com>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Phil Sutter" <phil@nwl.cc>,
"Yonghong Song" <yonghong.song@linux.dev>,
"Jens Axboe" <axboe@kernel.dk>,
"Jozsef Kadlecsik" <kadlec@netfilter.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"KP Singh" <kpsingh@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Florian Westphal" <fw@strlen.de>, "Jiri Olsa" <jolsa@kernel.org>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Song Liu" <song@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Simon Horman" <horms@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Tejun Heo" <tj@kernel.org>, "Josef Bacik" <josef@toxicpanda.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Yu Kuai" <yukuai@fnnas.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Kees Cook" <kees@kernel.org>, "Jakub Kicinski" <kuba@kernel.org>
Subject: [PATCH 0/4] Use __counted_by for ancestor arrays
Date: Wed, 17 Dec 2025 17:27:32 +0100 [thread overview]
Message-ID: <20251217162744.352391-1-mkoutny@suse.com> (raw)
The trick with utilizing space in cgroup_root for cgroup::ancetors flex
array was an obstacle for kernel reworks for
-Wflex-array-member-not-at-end.
The first patch fixes that, then I wanted to utilize __counted_by for
this flex array which required some more rework how cgroup level is
evaluated.
Similar flex array is also in struct ioc_gq where it was tempting to
simply use __counted_by(level), however, this would be off-by-one as it
has semantics like cgroup's level (0 == root).
Proper adjustment for __counted_by() would either need similar
level/ancestor helpers or abstracted macros for ancestors up/down
iterations.
I only made a simple comment fixup since I'm not sure about benefit of
__counted_by for structs that aren't sized based on direct user input.
Michal Koutný (4):
cgroup: Eliminate cgrp_ancestor_storage in cgroup_root
cgroup: Introduce cgroup_level() helper
cgroup: Use __counted_by for cgroup::ancestors
blk-iocost: Correct comment ioc_gq::level
block/bfq-iosched.c | 2 +-
block/blk-iocost.c | 6 ++---
include/linux/cgroup-defs.h | 43 +++++++++++++++++++----------------
include/linux/cgroup.h | 18 ++++++++++++---
include/trace/events/cgroup.h | 8 +++----
kernel/bpf/helpers.c | 2 +-
kernel/cgroup/cgroup.c | 9 ++++----
net/netfilter/nft_socket.c | 2 +-
8 files changed, 53 insertions(+), 37 deletions(-)
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
--
2.52.0
next reply other threads:[~2025-12-17 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 16:27 Michal Koutný [this message]
2025-12-17 16:27 ` [PATCH 2/4] cgroup: Introduce cgroup_level() helper Michal Koutný
2025-12-17 16:46 ` bot+bpf-ci
2025-12-20 14:59 ` kernel test robot
2025-12-20 21:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217162744.352391-1-mkoutny@suse.com \
--to=mkoutny@suse.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=gustavoars@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kadlec@netfilter.org \
--cc=kees@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=yonghong.song@linux.dev \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).