From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D97EC29CE9; Thu, 18 Dec 2025 17:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766079140; cv=none; b=aKUkLwVd1VG3IAsmtY8RpMRyLjhb+y0YjVppdme6FZyKijcihGgQKXoalrKxdL97CV87oH+y2/8zsvr0KA62A522BkoxCfuDCB4cw7mQefjnDmu55VGKJqY5VUA+S89uYGkcCroprXW8cRKQ93YV8cg7JlCMUy5x2unxCiYp36M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766079140; c=relaxed/simple; bh=cccgTe8Nws3IyH9tApyvnrXtg5pbgNdgHc6uiSZMtf8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Azbs0RYIPewcIC4Dz71dswrtFh4GoBN6S67ykyKTu9gq6O5U6ao7GnqrUdPuI5II5/hAtR6xbjlwRa7MyIvSlsBTaGMf/pd5DQdrYdFxAnpy9XXkRVkbcKzlFt+D2CoOwrOrQWMD86nISlD2IUTRQdxx5YVXI+shP013ND8ugew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B8DBF57DCF; Thu, 18 Dec 2025 17:32:15 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf05.hostedemail.com (Postfix) with ESMTPA id A5CBC20010; Thu, 18 Dec 2025 17:32:10 +0000 (UTC) Date: Thu, 18 Dec 2025 12:33:49 -0500 From: Steven Rostedt To: Yury Norov Cc: Randy Dunlap , Andrew Morton , Masami Hiramatsu , Mathieu Desnoyers , Andy Shevchenko , Christophe Leroy , Ingo Molnar , Jani Nikula , Joonas Lahtinen , David Laight , Petr Pavlu , Andi Shyti , Rodrigo Vivi , Tvrtko Ursulin , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH v3 4/4] tracing: move tracing declarations from kernel.h to a dedicated header Message-ID: <20251218123349.35339242@gandalf.local.home> In-Reply-To: References: <20251205175237.242022-1-yury.norov@gmail.com> <20251205175237.242022-5-yury.norov@gmail.com> <20251216161316.45b3f19ff0ad482018137189@linux-foundation.org> <55ceb7bf-0fe9-4edc-81c2-d51366847eec@infradead.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: hstzp6jteuufahd8q6tbcbnu46w15qog X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: A5CBC20010 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX193iJQpA7vys13S/A00XWgKxgoic14KwFA= X-HE-Tag: 1766079130-761500 X-HE-Meta: U2FsdGVkX1+MDvlruJ4hCiAq6JyjhNVuoOt/+vTnkbslcBiVQppXeci/OrgDqKbYzMF2OqLIRn5OzKrFPJjXdCPPn385+D1s67gmpvpgMoaxesaBMAzxSmVtxhanBJ3Yx5s7XDyGfjDyBTSACg89xFOD+5lI/QFm82ei4hCrgFakIlR8FIUCuzsYjVTZJD/T2716BWYF32eM4b6OQS6B/v1pgsVJFfhZNFkX1PmbrZdi59lkqFxW7KXY2RqvP3PwdgnVokOheLDjJcRcCAh/3zq6Ry16+SXHUCwgtga7pPtvXvAMWgV97192jRHneaB6ZEpWph+zCEajWm+gfc1KRlwp/CG0UD+N On Wed, 17 Dec 2025 22:59:33 -0500 Yury Norov wrote: > I deem to drop trace_printk.h from kernel.h - it is more aligned with > the idea of unloading the header. The original motivation to keep > trace_printk.h in kernel.h was just because a similar printk.h is living > there. But after all, this is a purely debugging header, so no need for > almost every C file to bear debugging stuff. It is a big deal for debugging stuff. A lot of developers debug their code with trace_printk(), and do the "shotgun approach", where they cut and paste trace_printk()s all over their code in several files. Having to now add: #include whenever a trace_printk() is added is going to be a big PITA and slow down all debugging efforts. -- Steve