From: Steven Rostedt <rostedt@goodmis.org>
To: Leon Hwang <leon.hwang@linux.dev>
Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
kerneljasonxing@gmail.com, lance.yang@linux.dev,
jiayuan.chen@linux.dev, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Leon Huang Fu <leon.huangfu@shopee.com>
Subject: Re: [PATCH net-next v2] page_pool: Add page_pool_release_stalled tracepoint
Date: Fri, 2 Jan 2026 10:45:04 -0500 [thread overview]
Message-ID: <20260102104504.7f593441@gandalf.local.home> (raw)
In-Reply-To: <20260102061718.210248-1-leon.hwang@linux.dev>
On Fri, 2 Jan 2026 14:17:18 +0800
Leon Hwang <leon.hwang@linux.dev> wrote:
> diff --git a/include/trace/events/page_pool.h b/include/trace/events/page_pool.h
> index 31825ed30032..c34de6a5ae80 100644
> --- a/include/trace/events/page_pool.h
> +++ b/include/trace/events/page_pool.h
> @@ -113,6 +113,30 @@ TRACE_EVENT(page_pool_update_nid,
> __entry->pool, __entry->pool_nid, __entry->new_nid)
> );
>
> +TRACE_EVENT(page_pool_release_stalled,
> +
> + TP_PROTO(const struct page_pool *pool, int inflight, int sec),
> +
> + TP_ARGS(pool, inflight, sec),
> +
> + TP_STRUCT__entry(
> + __field(const struct page_pool *, pool)
> + __field(u32, id)
> + __field(int, inflight)
> + __field(int, sec)
> + ),
> +
> + TP_fast_assign(
> + __entry->pool = pool;
> + __entry->id = pool->user.id;
> + __entry->inflight = inflight;
> + __entry->sec = sec;
> + ),
> +
> + TP_printk("page_pool=%p id=%d inflight=%d sec=%d",
> + __entry->pool, __entry->id, __entry->inflight, __entry->sec)
> +);
> +
> #endif /* _TRACE_PAGE_POOL_H */
From a tracing POV, I see nothing wrong with this.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2026-01-02 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 6:17 [PATCH net-next v2] page_pool: Add page_pool_release_stalled tracepoint Leon Hwang
2026-01-02 15:45 ` Steven Rostedt [this message]
2026-01-02 15:54 ` Leon Hwang
2026-01-02 18:00 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102104504.7f593441@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jiayuan.chen@linux.dev \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=lance.yang@linux.dev \
--cc=leon.huangfu@shopee.com \
--cc=leon.hwang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).