From: Steven Rostedt <rostedt@goodmis.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: pengdonglin <pengdonglin@xiaomi.com>, linux-trace-kernel@vger.kernel.org
Subject: Re: [bug report] function_graph: Enable funcgraph-args and funcgraph-retaddr to work simultaneously
Date: Fri, 2 Jan 2026 13:58:23 -0500 [thread overview]
Message-ID: <20260102135823.37578148@gandalf.local.home> (raw)
In-Reply-To: <20260102135630.0a5d91fb@gandalf.local.home>
On Fri, 2 Jan 2026 13:56:30 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> > 1031 /* Save this function pointer to see if the exit matches */
> > 1032 if (call->depth < FTRACE_RETFUNC_DEPTH &&
> > --> 1033 !WARN_ON_ONCE(call->depth < 0))
> > ^^^^^^^^^^^^^^^
> > The patch changed call->depth from int to unsigned long.
>
> Yep, I'm fixing this with:
>
> !WARN_ON_ONCE((long)call->depth < 0))
>
Thinking about this more. I think it is more robust to change depth to
"long" from "unsigned long" in case there's other locations that expect
depth to be signed.
-- Steve
prev parent reply other threads:[~2026-01-02 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 8:32 [bug report] function_graph: Enable funcgraph-args and funcgraph-retaddr to work simultaneously Dan Carpenter
2026-01-02 18:56 ` Steven Rostedt
2026-01-02 18:58 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102135823.37578148@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=pengdonglin@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).