From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D72E8331A70 for ; Wed, 7 Jan 2026 13:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767792165; cv=none; b=oC/O2flwkUhqRB99Ryb4hqPrTXLO5bnVf6pysUykCfoo0I7y087R1l3vWTvHy6CIc8NRyuy/68W3l2rHGkISrzZ/PPJ6uW+3xjQrzxsYRq38zfbfWvsYX/XruCIfhMxS2MVFzSZPHEFYx1yBXrJExrcecwZTRsZBK0y68p6dbkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767792165; c=relaxed/simple; bh=unytFKZ8LCGZbWiIqqle1BjuJ9OKga7Krn0YjNtEcU4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZFd5TcvrmPhx9oIgT2Wqwtm04VEz7H60Y87kc0OwEbZxzSEqVCy8puq4TaN5QcYfZ/AB8HE2vxjMb0XPZAYVd/63ebv++3abOmlnE7P03FxVt48wQHRz4aSQiNppoWL18yBzy6owgGBp028dOQLW/qp7S/qum1POIX+NmXDNaKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SOnitJg+; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SOnitJg+" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a099233e8dso16871335ad.3 for ; Wed, 07 Jan 2026 05:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767792163; x=1768396963; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=htJmJ2nOl5HS2d4lrmu4G6awIswx3aqJ66sxEqxOU2k=; b=SOnitJg+hVNmVJlkwgk6o2H6/EhOte0DlJvlj8MJEn0dEWu0JMlQzYioj0qc3CIS1k H1ooZnU2xiniV7uT2rzxd2ZIa4Mx0SwC5yS3A0Covjgq5DzIslb14tDyddB/o55gYEaK Vp4Sw6tbLDxVZ6SXZDdKlQ4sJuiR0sfMbDzycke8XaMV9ujj0rh8S2F1dSUZBXjD+OBL gR1HN9GgQB5/GAZ3tNwHin6NSHdCnGj7UxjineA1dJuvAHI5Rxsgq+sQP7Quk3zSWnvS mUeb9TsipgTtm2aR2TMufCulDuurhfjCt6LCQ+WVoVyNsZCa1rSkK67jbZ4q0wUFBELL GguQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767792163; x=1768396963; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=htJmJ2nOl5HS2d4lrmu4G6awIswx3aqJ66sxEqxOU2k=; b=TfdQCsyqK+p0DgnKBtD2SuWN0UhpcAiqX1Kp4jN7VEtFYLgr8q07PMM2io78Z/rxzh k3md3OlfhE03xsVTBMqAnpi3mreqhvP2pnHHQisvaRiubTCuHw7z+sBhyP+murtpIgJq 3O25KIN1c3rIf0ifZeywTvYJZrrT/uPCsQTSq/z3Q23ibYrsJraH35OpbpEayUtHK0ql iLqYS4Pb6wGFF+lLJkd+9DxtROZAeom9gVdoRhpS5/HNz4pB0py/v7dGs2KWyQP7HbN5 2ykDzHHNCuLNMCN9S9wivcDrrlKt0/MJ+RPd1mu61+QrhARzYg++9qjtqZ+hcgfvVlML dFFQ== X-Forwarded-Encrypted: i=1; AJvYcCVsdwWU+Aiyi1ly3BgWMIoY10jVzfk/1c6UxMJKeRmySHykZWJHIQA+Akm+N/pc+WCq3hkZIGw7LuH50PIbrZqpU1g=@vger.kernel.org X-Gm-Message-State: AOJu0YzkLLJ7KpZzEbgJY3PZbfI5u+CTpVAQohrJULEY+zPeAqWRaj8P ns7zMBdgn1Lk9ZiE+wc63OGNc+WDKJB75B4J1aTl3E8+AsJgumA5KZ+V X-Gm-Gg: AY/fxX6gs6arktXYqdO38LoEAJHAzFibzK/NV+wDf1E3ZMJz6NOX282ShKs0KceXV/0 THTFcFOxalSjj9YS3JWfSYw++h1tGktG1JyclXUM8d6TBbWfeiYoh0h8MJMg8x45tbgJfoRgLoR YjNFUTCR8RGYBrqJ1e94h/XEfRw7uQCIcfIFTJbMWW7T2wjBQN5To6p1GgLFalYTKy7VEGhZVau SwDgjCVeSjDL7+SpXeOkOUFa+RV+QO7b3HT25FVhliYH4zDrn1oWDTz060S7nK5cS7ED/UwYhes YZdfvhm6SeL0SFy68DHaIs+Ejg/gir6iH5Mg29IIZaJ96J5CVcKo+N/1gVR8+3yxCIV6eisQHKC JCsjlEPLyCJd5aTCxvBm32uUTvn4bRxpqntBzeyIVvgicZgEz+8poHKdMy4ZofOZUpifWBmXThM b2lzoDiPr22uRCtKypUmA33w== X-Google-Smtp-Source: AGHT+IEvtZa3zLpS6a5Y/+nmtOmpeeuGMbTxkqCETXk3Efe8UmRkWBRknzvf6eczc+NkOyxjXeazrg== X-Received: by 2002:a17:902:daca:b0:2a0:da38:96d8 with SMTP id d9443c01a7336-2a3ee443bf0mr20830455ad.25.1767792162588; Wed, 07 Jan 2026 05:22:42 -0800 (PST) Received: from [127.0.0.1] ([188.253.121.152]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc7912sm52511685ad.67.2026.01.07.05.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 05:22:42 -0800 (PST) From: Zesen Liu Date: Wed, 07 Jan 2026 21:21:43 +0800 Subject: [PATCH bpf v2 2/2] bpf: Require ARG_PTR_TO_MEM with memory flag Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260107-helper_proto-v2-2-4c562bcca5a8@gmail.com> References: <20260107-helper_proto-v2-0-4c562bcca5a8@gmail.com> In-Reply-To: <20260107-helper_proto-v2-0-4c562bcca5a8@gmail.com> To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Matt Bobrowski , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Daniel Xu Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, Shuran Liu , Peili Gao , Haoran Ni , Zesen Liu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1786; i=ftyghome@gmail.com; h=from:subject:message-id; bh=unytFKZ8LCGZbWiIqqle1BjuJ9OKga7Krn0YjNtEcU4=; b=owGbwMvMwCXWI1/u+8bXqJ3xtFoSQ2ZcHKfXnRfM7Bz8sbOPtxaeKuSre5UuvjNs77NkU+Od5 73+er3tKGVhEONikBVTZOn9YXh3Zaa58TabBQdh5rAygQxh4OIUgIkcimX47yj3//irmXOKCkSf py4VeqYl3l5yOXj/g2anJTI2DKcUvjEydH6csH5bW6CMziyV3XniFTfVHzjWFVxWcK590+SR4Di LCQA= X-Developer-Key: i=ftyghome@gmail.com; a=openpgp; fpr=8DF831DDA9693733B63CA0C18C1F774DEC4D3287 Add check to ensure that ARG_PTR_TO_MEM is used with either MEM_WRITE or MEM_RDONLY. Using ARG_PTR_TO_MEM alone without tags does not make sense because: - If the helper does not change the argument, missing MEM_RDONLY causes the verifier to incorrectly reject a read-only buffer. - If the helper does change the argument, missing MEM_WRITE causes the verifier to incorrectly assume the memory is unchanged, leading to errors in code optimization. Co-developed-by: Shuran Liu Signed-off-by: Shuran Liu Co-developed-by: Peili Gao Signed-off-by: Peili Gao Co-developed-by: Haoran Ni Signed-off-by: Haoran Ni Signed-off-by: Zesen Liu --- kernel/bpf/verifier.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index f0ca69f888fa..c7ebddb66385 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -10349,10 +10349,27 @@ static bool check_btf_id_ok(const struct bpf_func_proto *fn) return true; } +static bool check_mem_arg_rw_flag_ok(const struct bpf_func_proto *fn) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(fn->arg_type); i++) { + enum bpf_arg_type arg_type = fn->arg_type[i]; + + if (base_type(arg_type) != ARG_PTR_TO_MEM) + continue; + if (!(arg_type & (MEM_WRITE | MEM_RDONLY))) + return false; + } + + return true; +} + static int check_func_proto(const struct bpf_func_proto *fn, int func_id) { return check_raw_mode_ok(fn) && check_arg_pair_ok(fn) && + check_mem_arg_rw_flag_ok(fn) && check_btf_id_ok(fn) ? 0 : -EINVAL; } -- 2.43.0