From: Fushuai Wang <fushuai.wang@linux.dev>
To: tglx@kernel.org, peterz@infradead.org,
mathieu.desnoyers@efficios.com, akpm@linux-foundation.org,
aliceryhl@google.com, yury.norov@gmail.com, vmalik@redhat.com,
kees@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
rostedt@goodmis.org, mhiramat@kernel.org, brauner@kernel.org,
jack@suse.cz, cyphar@cyphar.com
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-trace-kernel@vger.kernel.org, wangfushuai@baidu.com
Subject: [PATCH v2 1/6] uaccess: Add copy_from_user_nul helper
Date: Mon, 12 Jan 2026 15:30:34 +0800 [thread overview]
Message-ID: <20260112073039.1185-2-fushuai.wang@linux.dev> (raw)
In-Reply-To: <20260112073039.1185-1-fushuai.wang@linux.dev>
From: Fushuai Wang <wangfushuai@baidu.com>
Many places call copy_from_user() to copy a buffer from user space,
and then manually add a NULL terminator to the destination buffer,
e.g.:
if (copy_from_user(dest, src, len))
return -EFAULT;
dest[len] = '\0';
This is repetitive and error-prone. Add a copy_from_user_nul() helper to
simplify such patterns. It copied n bytes from user space to kernel space,
and NUL-terminates the destination buffer.
Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
---
include/linux/uaccess.h | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
index 1f3804245c06..fe9a1db600c7 100644
--- a/include/linux/uaccess.h
+++ b/include/linux/uaccess.h
@@ -224,6 +224,25 @@ copy_from_user(void *to, const void __user *from, unsigned long n)
#endif
}
+/*
+ * copy_from_user_nul - Copy a block of data from user space and NUL-terminate
+ *
+ * @to: Destination address, in kernel space. This buffer must be at least
+ * @n+1 bytes long!
+ * @from: Source address, in user space.
+ * @n: Number of bytes to copy.
+ *
+ * Return: 0 on success, -EFAULT on failure.
+ */
+static __always_inline int __must_check
+copy_from_user_nul(void *to, const void __user *from, unsigned long n)
+{
+ if (copy_from_user(to, from, n))
+ return -EFAULT;
+ ((char *)to)[n] = '\0';
+ return 0;
+}
+
static __always_inline unsigned long __must_check
copy_to_user(void __user *to, const void *from, unsigned long n)
{
--
2.36.1
next prev parent reply other threads:[~2026-01-12 7:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 7:30 [PATCH v2 0/6] uaccess: Introduce copy_from_user_nul helper Fushuai Wang
2026-01-12 7:30 ` Fushuai Wang [this message]
2026-01-12 9:23 ` [PATCH v2 1/6] uaccess: Add " Alice Ryhl
2026-01-12 10:00 ` Fushuai Wang
2026-01-12 11:20 ` Alice Ryhl
2026-01-12 12:22 ` Fushuai Wang
2026-01-12 13:22 ` Borislav Petkov
2026-01-12 15:40 ` Alice Ryhl
2026-01-12 16:28 ` Steven Rostedt
2026-01-12 16:37 ` Alice Ryhl
2026-01-13 18:00 ` Yury Norov
2026-01-13 18:17 ` Yury Norov
2026-01-16 8:42 ` Fushuai Wang
2026-01-12 7:30 ` [PATCH v2 2/6] x86/tlb: Use copy_from_user_nul() instead of copy_from_user() Fushuai Wang
2026-01-12 7:30 ` [PATCH v2 3/6] tracing: " Fushuai Wang
2026-01-12 15:43 ` Steven Rostedt
2026-01-13 17:05 ` Yury Norov
2026-01-13 18:03 ` Steven Rostedt
2026-01-12 7:30 ` [PATCH v2 4/6] userns: " Fushuai Wang
2026-01-12 7:30 ` [PATCH v2 5/6] time: " Fushuai Wang
2026-01-12 7:30 ` [PATCH v2 6/6] kstrtox: " Fushuai Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112073039.1185-2-fushuai.wang@linux.dev \
--to=fushuai.wang@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@kernel.org \
--cc=vmalik@redhat.com \
--cc=wangfushuai@baidu.com \
--cc=x86@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox