public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wander Lairson Costa <wander@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Tomas Glozar <tglozar@redhat.com>,
	Wander Lairson Costa <wander@redhat.com>,
	Crystal Wood <crwood@redhat.com>,
	Ivan Pravdin <ipravdin.official@gmail.com>,
	Costa Shulyupin <costa.shul@redhat.com>,
	John Kacur <jkacur@redhat.com>,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	Daniel Wagner <dwagner@suse.de>,
	Daniel Bristot de Oliveira <bristot@kernel.org>,
	linux-trace-kernel@vger.kernel.org (open list:Real-time Linux
	Analysis (RTLA) tools),
	linux-kernel@vger.kernel.org (open list:Real-time Linux Analysis
	(RTLA) tools),
	bpf@vger.kernel.org (open list:BPF
	[MISC]:Keyword:(?:\b|_)bpf(?:\b|_))
Subject: [PATCH v3 02/18] rtla: Use strdup() to simplify code
Date: Thu, 15 Jan 2026 13:31:45 -0300	[thread overview]
Message-ID: <20260115163650.118910-3-wander@redhat.com> (raw)
In-Reply-To: <20260115163650.118910-1-wander@redhat.com>

The actions_add_trace_output() and actions_add_shell() functions were
using calloc() followed by strcpy() to allocate and copy a string.
This can be simplified by using strdup(), which allocates memory and
copies the string in a single step.

Replace the calloc() and strcpy() calls with strdup(), making the
code more concise and readable.

Signed-off-by: Wander Lairson Costa <wander@redhat.com>
---
 tools/tracing/rtla/src/actions.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/tracing/rtla/src/actions.c b/tools/tracing/rtla/src/actions.c
index 22b8283a183f3..0ac42ffd734a3 100644
--- a/tools/tracing/rtla/src/actions.c
+++ b/tools/tracing/rtla/src/actions.c
@@ -69,8 +69,7 @@ actions_add_trace_output(struct actions *self, const char *trace_output)
 
 	self->present[ACTION_TRACE_OUTPUT] = true;
 	action->type = ACTION_TRACE_OUTPUT;
-	action->trace_output = calloc_fatal(strlen(trace_output) + 1, sizeof(char));
-	strcpy(action->trace_output, trace_output);
+	action->trace_output = strdup_fatal(trace_output);
 }
 
 /*
@@ -97,8 +96,7 @@ actions_add_shell(struct actions *self, const char *command)
 
 	self->present[ACTION_SHELL] = true;
 	action->type = ACTION_SHELL;
-	action->command = calloc_fatal(strlen(command) + 1, sizeof(char));
-	strcpy(action->command, command);
+	action->command = strdup_fatal(command);
 }
 
 /*
-- 
2.52.0


  parent reply	other threads:[~2026-01-15 17:25 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 16:31 [PATCH v3 00/18] rtla: Robustness and code quality improvements Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 01/18] rtla: Exit on memory allocation failures during initialization Wander Lairson Costa
2026-01-15 16:31 ` Wander Lairson Costa [this message]
2026-01-15 16:31 ` [PATCH v3 03/18] rtla: Simplify argument parsing Wander Lairson Costa
2026-01-15 21:47   ` Costa Shulyupin
2026-01-16 11:38     ` Wander Lairson Costa
2026-03-03 11:58   ` Tomas Glozar
2026-01-15 16:31 ` [PATCH v3 04/18] rtla: Introduce common_threshold_handler() helper Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 05/18] rtla: Replace magic number with MAX_PATH Wander Lairson Costa
2026-03-03 12:46   ` Tomas Glozar
2026-01-15 16:31 ` [PATCH v3 06/18] rtla: Simplify code by caching string lengths Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 07/18] rtla: Add strscpy() and replace strncpy() calls Wander Lairson Costa
2026-03-02 14:33   ` Tomas Glozar
2026-03-03 11:02     ` Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 08/18] rtla/timerlat: Add bounds check for softirq vector Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 09/18] rtla: Handle pthread_create() failure properly Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 10/18] rtla: Add str_has_prefix() helper function Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 11/18] rtla: Use str_has_prefix() for prefix checks Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 12/18] rtla: Enforce exact match for time unit suffixes Wander Lairson Costa
2026-03-03 14:27   ` Tomas Glozar
2026-03-09 17:17     ` Wander Lairson Costa
2026-03-04 13:57   ` Tomas Glozar
2026-03-09 17:15     ` Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 13/18] rtla: Use str_has_prefix() for option prefix check Wander Lairson Costa
2026-01-15 16:31 ` [PATCH v3 14/18] rtla/timerlat: Simplify RTLA_NO_BPF environment variable check Wander Lairson Costa
2026-03-03 14:38   ` Tomas Glozar
2026-01-15 16:31 ` [PATCH v3 15/18] rtla/trace: Fix write loop in trace_event_save_hist() Wander Lairson Costa
2026-03-03 14:51   ` Tomas Glozar
2026-01-15 16:31 ` [PATCH v3 16/18] rtla/trace: Fix I/O handling in save_trace_to_file() Wander Lairson Costa
2026-03-04 10:30   ` Tomas Glozar
2026-03-09 16:46     ` Wander Lairson Costa
2026-01-15 16:32 ` [PATCH v3 17/18] rtla/utils: Fix resource leak in set_comm_sched_attr() Wander Lairson Costa
2026-01-15 16:32 ` [PATCH v3 18/18] rtla/utils: Fix loop condition in PID validation Wander Lairson Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115163650.118910-3-wander@redhat.com \
    --to=wander@redhat.com \
    --cc=bpf@vger.kernel.org \
    --cc=bristot@kernel.org \
    --cc=costa.shul@redhat.com \
    --cc=crwood@redhat.com \
    --cc=dwagner@suse.de \
    --cc=ipravdin.official@gmail.com \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglozar@redhat.com \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox