From: Wander Lairson Costa <wander@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Gabriele Monaco <gmonaco@redhat.com>,
Nam Cao <namcao@linutronix.de>,
Wander Lairson Costa <wander@redhat.com>,
linux-kernel@vger.kernel.org (open list),
linux-trace-kernel@vger.kernel.org (open list:RUNTIME
VERIFICATION (RV))
Subject: [PATCH 14/26] rv/rvgen: remove redundant initial_state removal
Date: Mon, 19 Jan 2026 17:45:50 -0300 [thread overview]
Message-ID: <20260119205601.105821-15-wander@redhat.com> (raw)
In-Reply-To: <20260119205601.105821-1-wander@redhat.com>
Remove an unnecessary and incorrect list removal operation in the
automata state variable processing. The code attempted to remove
initial_state from the states list, but this element was never
added to the list in the first place. States with the __init_
prefix are explicitly excluded from the states list during the
parsing loop, with only the initial_state variable being set
from them.
Calling remove() on an element that does not exist in a list
raises a ValueError. This code would have failed during execution
when processing any DOT file containing an initial state marker.
The subsequent insert operation at index 0 correctly adds the
initial_state to the beginning of the states list, making the
removal operation both incorrect and redundant.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
---
tools/verification/rvgen/rvgen/automata.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/verification/rvgen/rvgen/automata.py b/tools/verification/rvgen/rvgen/automata.py
index 7841a6e70bad2..b302af3e5133e 100644
--- a/tools/verification/rvgen/rvgen/automata.py
+++ b/tools/verification/rvgen/rvgen/automata.py
@@ -111,7 +111,6 @@ class Automata:
cursor += 1
states = sorted(set(states))
- states.remove(initial_state)
# Insert the initial state at the beginning of the states
states.insert(0, initial_state)
--
2.52.0
next prev parent reply other threads:[~2026-01-19 21:04 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 20:45 [PATCH 00/26] rv/rvgen: Robustness, modernization, and fixes Wander Lairson Costa
2026-01-19 20:45 ` [PATCH 01/26] rv/rvgen: introduce AutomataError exception class Wander Lairson Costa
2026-01-20 7:33 ` Gabriele Monaco
2026-01-20 12:39 ` Wander Lairson Costa
2026-01-20 15:08 ` Gabriele Monaco
2026-01-22 14:39 ` Nam Cao
2026-01-19 20:45 ` [PATCH 02/26] rv/rvgen: remove bare except clauses in generator Wander Lairson Costa
2026-01-20 10:05 ` Gabriele Monaco
2026-01-22 14:43 ` Nam Cao
2026-01-19 20:45 ` [PATCH 03/26] rv/rvgen: replace % string formatting with f-strings Wander Lairson Costa
2026-01-20 10:02 ` Gabriele Monaco
2026-01-22 14:46 ` Nam Cao
2026-01-19 20:45 ` [PATCH 04/26] rv/rvgen: replace __len__() calls with len() Wander Lairson Costa
2026-01-20 7:41 ` Gabriele Monaco
2026-01-22 14:46 ` Nam Cao
2026-01-19 20:45 ` [PATCH 05/26] rv/rvgen: remove unnecessary semicolons Wander Lairson Costa
2026-01-20 7:42 ` Gabriele Monaco
2026-01-22 14:47 ` Nam Cao
2026-01-19 20:45 ` [PATCH 06/26] rv/rvgen: use context managers for file operations Wander Lairson Costa
2026-01-20 7:44 ` Gabriele Monaco
2026-01-22 14:50 ` Nam Cao
2026-01-19 20:45 ` [PATCH 07/26] rv/rvgen: replace __contains__() with in operator Wander Lairson Costa
2026-01-20 7:45 ` Gabriele Monaco
2026-01-22 14:51 ` Nam Cao
2026-01-19 20:45 ` [PATCH 08/26] rv/rvgen: simplify boolean comparison Wander Lairson Costa
2026-01-20 7:48 ` Gabriele Monaco
2026-01-22 14:51 ` Nam Cao
2026-01-19 20:45 ` [PATCH 09/26] rv/rvgen: replace inline NotImplemented with decorator Wander Lairson Costa
2026-01-21 13:43 ` Gabriele Monaco
2026-01-21 17:49 ` Wander Lairson Costa
2026-01-22 14:57 ` Nam Cao
2026-01-19 20:45 ` [PATCH 10/26] rv/rvgen: fix typos in automata docstring and comments Wander Lairson Costa
2026-01-22 14:58 ` Nam Cao
2026-01-19 20:45 ` [PATCH 11/26] rv/rvgen: fix typo in generator module docstring Wander Lairson Costa
2026-01-20 7:51 ` Gabriele Monaco
2026-01-22 14:59 ` Nam Cao
2026-01-19 20:45 ` [PATCH 12/26] rv/rvgen: fix PEP 8 whitespace violations Wander Lairson Costa
2026-01-20 7:53 ` Gabriele Monaco
2026-01-22 14:59 ` Nam Cao
2026-01-19 20:45 ` [PATCH 13/26] rv/rvgen: fix DOT file validation logic error Wander Lairson Costa
2026-01-20 7:56 ` Gabriele Monaco
2026-01-22 15:01 ` Nam Cao
2026-01-19 20:45 ` Wander Lairson Costa [this message]
2026-01-20 8:01 ` [PATCH 14/26] rv/rvgen: remove redundant initial_state removal Gabriele Monaco
2026-01-20 12:05 ` Wander Lairson Costa
2026-01-19 20:45 ` [PATCH 15/26] rv/rvgen: use class constant for init marker Wander Lairson Costa
2026-01-20 8:06 ` Gabriele Monaco
2026-01-22 15:02 ` Nam Cao
2026-01-19 20:45 ` [PATCH 16/26] rv/rvgen: fix unbound initial_state variable Wander Lairson Costa
2026-01-20 8:21 ` Gabriele Monaco
2026-01-20 11:42 ` Wander Lairson Costa
2026-01-20 11:53 ` Gabriele Monaco
2026-01-19 20:45 ` [PATCH 17/26] rv/rvgen: fix possibly unbound variable in ltl2k Wander Lairson Costa
2026-01-20 8:59 ` Gabriele Monaco
2026-01-20 11:37 ` Wander Lairson Costa
2026-01-20 12:30 ` Gabriele Monaco
2026-01-20 19:38 ` Wander Lairson Costa
2026-01-21 6:31 ` Gabriele Monaco
2026-01-22 15:31 ` Nam Cao
2026-01-19 20:45 ` [PATCH 18/26] rv/rvgen: add fill_tracepoint_args_skel stub to ltl2k Wander Lairson Costa
2026-01-21 13:57 ` Gabriele Monaco
2026-01-21 17:53 ` Wander Lairson Costa
2026-01-22 13:10 ` Wander Lairson Costa
2026-01-22 13:49 ` Gabriele Monaco
2026-01-23 12:19 ` Wander Lairson Costa
2026-01-23 12:26 ` Gabriele Monaco
2026-01-23 14:04 ` Wander Lairson Costa
2026-01-19 20:45 ` [PATCH 19/26] rv/rvgen: add abstract method stubs to Container class Wander Lairson Costa
2026-01-21 13:59 ` Gabriele Monaco
2026-01-21 17:56 ` Wander Lairson Costa
2026-01-22 15:33 ` Nam Cao
2026-01-19 20:45 ` [PATCH 20/26] rv/rvgen: refactor automata.py to use iterator-based parsing Wander Lairson Costa
2026-01-20 9:43 ` Gabriele Monaco
2026-01-22 15:35 ` Nam Cao
2026-01-22 15:40 ` Gabriele Monaco
2026-01-22 16:01 ` Nam Cao
2026-01-19 20:45 ` [PATCH 21/26] rv/rvgen: remove unused sys import from dot2c Wander Lairson Costa
2026-01-20 9:16 ` Gabriele Monaco
2026-01-19 20:45 ` [PATCH 22/26] rv/rvgen: remove unused __get_main_name method Wander Lairson Costa
2026-01-20 9:08 ` Gabriele Monaco
2026-01-19 20:45 ` [PATCH 23/26] rv/rvgen: add type annotations to fix pyright errors Wander Lairson Costa
2026-01-22 15:43 ` Nam Cao
2026-01-19 20:46 ` [PATCH 24/26] rv/rvgen: make monitor arguments required in rvgen Wander Lairson Costa
2026-01-20 9:07 ` Gabriele Monaco
2026-01-22 15:44 ` Nam Cao
2026-01-19 20:46 ` [PATCH 25/26] rv/rvgen: fix isinstance check in Variable.expand() Wander Lairson Costa
2026-01-22 15:53 ` Nam Cao
2026-01-19 20:46 ` [PATCH 26/26] rv/rvgen: extract node marker string to class constant Wander Lairson Costa
2026-01-20 9:03 ` Gabriele Monaco
2026-01-20 11:34 ` Wander Lairson Costa
2026-01-20 12:36 ` Gabriele Monaco
2026-01-20 13:11 ` Gabriele Monaco
2026-01-20 18:56 ` Wander Lairson Costa
2026-01-21 6:16 ` Gabriele Monaco
2026-01-20 7:20 ` [PATCH 00/26] rv/rvgen: Robustness, modernization, and fixes Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119205601.105821-15-wander@redhat.com \
--to=wander@redhat.com \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox