From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] tracing: Remove backup instance after read all
Date: Tue, 20 Jan 2026 00:27:40 +0900 [thread overview]
Message-ID: <20260120002740.7962e180f9ea88006a32abb9@kernel.org> (raw)
In-Reply-To: <176828713313.2161268.62228177827727824.stgit@mhiramat.tok.corp.google.com>
I found another bug on this (or persistent ring buffer itself)
Let me fix it first.
On Tue, 13 Jan 2026 15:52:13 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> Hi,
>
> Here is the 3rd version of the series to improve backup instances of
> the persistent ring buffer. The previous version is here:
>
> https://lore.kernel.org/all/176788217131.1398317.11144318616426272901.stgit@mhiramat.tok.corp.google.com/
>
> In this version, I updated [1/2] to back to checking readonly
> flag and consolidate the eventfs_entries.
>
> Since backup instances are a kind of snapshot of the persistent
> ring buffer, it should be readonly. And if it is readonly
> there is no reason to keep it after reading all data via trace_pipe
> because the data has been consumed.
> Thus, [1/2] makes backup instances readonly (not able to write any
> events, cleanup trace, change buffer size). Also, [2/2] removes the
> backup instance after consuming all data via trace_pipe.
> With this improvements, even if we makes a backup instance (using
> the same amount of memory of the persistent ring buffer), it will
> be removed after reading the data automatically.
>
> ---
>
> Masami Hiramatsu (Google) (2):
> tracing: Make the backup instance readonly
> tracing: Add autoremove feature to the backup instance
>
>
> kernel/trace/trace.c | 164 +++++++++++++++++++++++++++++++++++--------
> kernel/trace/trace.h | 14 +++-
> kernel/trace/trace_boot.c | 5 +
> kernel/trace/trace_events.c | 68 +++++++++++-------
> 4 files changed, 191 insertions(+), 60 deletions(-)
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2026-01-19 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 6:52 [PATCH v3 0/2] tracing: Remove backup instance after read all Masami Hiramatsu (Google)
2026-01-13 6:52 ` [PATCH v3 1/2] tracing: Make the backup instance readonly Masami Hiramatsu (Google)
2026-01-13 6:52 ` [PATCH v3 2/2] tracing: Add autoremove feature to the backup instance Masami Hiramatsu (Google)
2026-01-19 15:27 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120002740.7962e180f9ea88006a32abb9@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox