public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Seokwoo Chung <seokwoo.chung130@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	mhiramat@kernel.org, corbet@lwn.net, shuah@kernel.org,
	mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 v5 1/3] docs: tracing/fprobe: Document list filters and :entry/:exit
Date: Thu, 29 Jan 2026 09:35:08 +0900	[thread overview]
Message-ID: <20260129093508.5064b3782a40811cbcd8cb7b@kernel.org> (raw)
In-Reply-To: <wqpijkdwziafpuci6js5mtfzro46bre4z7une547crcdzrlm67@kd4fgea5m6ov>

Hi Ryan,

On Sun, 25 Jan 2026 15:23:17 -0500
Seokwoo Chung <seokwoo.chung130@gmail.com> wrote:

> On Tue, Jan 20, 2026 at 03:53:40PM -0500, Steven Rostedt wrote:
> > On Sat, 17 Jan 2026 20:18:13 -0500
> > "Seokwoo Chung (Ryan)" <seokwoo.chung130@gmail.com> wrote:
> > 
> > > Update fprobe event documentation to describe comma-separated symbol lists,
> > > exclusions, and explicit suffixes.
> > 
> > Usually, the documentation updates comes *after* the changes.
> > 
> > -- Steve
> > 
> Thanks for the comment. As you noticed, I sent another patch since I forgot to
> put log. That said, please let me know if you want me to continue on this
> series. My apologies on the ordering. I noted after Masami mentioned but I
> misordered when sending. Thank you.

Sorry for replying so late,
Can you fix the kernel test robot's error? I think it is almost done.

Thank you,

> 
> Best regards,
> Ryan Chung
> > > 
> > > Signed-off-by: Seokwoo Chung (Ryan) <seokwoo.chung130@gmail.com>
> > > ---
> > >  Documentation/trace/fprobetrace.rst | 17 ++++++++++++++---
> > >  1 file changed, 14 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/trace/fprobetrace.rst b/Documentation/trace/fprobetrace.rst
> > > index b4c2ca3d02c1..bbcfd57f0005 100644
> > > --- a/Documentation/trace/fprobetrace.rst
> > > +++ b/Documentation/trace/fprobetrace.rst
> > > @@ -25,14 +25,18 @@ Synopsis of fprobe-events
> > >  -------------------------
> > >  ::
> > >  
> > > -  f[:[GRP1/][EVENT1]] SYM [FETCHARGS]                       : Probe on function entry
> > > -  f[MAXACTIVE][:[GRP1/][EVENT1]] SYM%return [FETCHARGS]     : Probe on function exit
> > > +  f[:[GRP1/][EVENT1]] SYM[%return] [FETCHARGS]		    : Single function
> > > +  f[:[GRP1/][EVENT1]] SYM[,[!]SYM[,...]][:entry|:exit] [FETCHARGS] :Multiple
> > > +  function
> > >    t[:[GRP2/][EVENT2]] TRACEPOINT [FETCHARGS]                : Probe on tracepoint
> > >  
> > >   GRP1           : Group name for fprobe. If omitted, use "fprobes" for it.
> > >   GRP2           : Group name for tprobe. If omitted, use "tracepoints" for it.
> > >   EVENT1         : Event name for fprobe. If omitted, the event name is
> > > -                  "SYM__entry" or "SYM__exit".
> > > +		  - For a single literal symbol, the event name is
> > > +		    "SYM__entry" or "SYM__exit".
> > > +		  - For a *list or any wildcard*, an explicit [GRP1/][EVENT1] is
> > > +		    required; otherwise the parser rejects it.
> > >   EVENT2         : Event name for tprobe. If omitted, the event name is
> > >                    the same as "TRACEPOINT", but if the "TRACEPOINT" starts
> > >                    with a digit character, "_TRACEPOINT" is used.
> > > @@ -40,6 +44,13 @@ Synopsis of fprobe-events
> > >                    can be probed simultaneously, or 0 for the default value
> > >                    as defined in Documentation/trace/fprobe.rst
> > >  
> > > + SYM		: Function name or comma-separated list of symbols.
> > > +		  - SYM prefixed with "!" are exclusions.
> > > +		  - ":entry" suffix means it probes entry of given symbols
> > > +		    (default)
> > > +		  - ":exit" suffix means it probes exit of given symbols.
> > > +		  - "%return" suffix means it probes exit of SYM (single
> > > +		    symbol).
> > >   FETCHARGS      : Arguments. Each probe can have up to 128 args.
> > >    ARG           : Fetch "ARG" function argument using BTF (only for function
> > >                    entry or tracepoint.) (\*1)
> > 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

  reply	other threads:[~2026-01-29  0:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-18  1:18 [PATCH v5 v5 0/3] tracing/fprobe: Support comma-separated symbols and :entry/:exit Seokwoo Chung (Ryan)
2026-01-18  1:18 ` [PATCH v5 v5 1/3] docs: tracing/fprobe: Document list filters " Seokwoo Chung (Ryan)
2026-01-20 20:53   ` Steven Rostedt
2026-01-25 20:23     ` Seokwoo Chung
2026-01-29  0:35       ` Masami Hiramatsu [this message]
2026-01-31 16:16         ` Seokwoo Chung
2026-01-18  1:18 ` [PATCH v5 v5 2/3] tracing/fprobe: Support comma-separated symbols " Seokwoo Chung (Ryan)
2026-01-18  6:36   ` kernel test robot
2026-01-29  4:24   ` Masami Hiramatsu
2026-01-18  1:18 ` [PATCH v5 v5 3/3] selftests/ftrace: Add accept cases for fprobe list syntax Seokwoo Chung (Ryan)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129093508.5064b3782a40811cbcd8cb7b@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=rostedt@goodmis.org \
    --cc=seokwoo.chung130@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox