Re: [PATCH v10 17/30] tracing: load/unload page callbacks for simple_ring_buffer

[Steven Rostedt <rostedt@goodmis.org>]

On Mon, 26 Jan 2026 10:44:06 +0000
Vincent Donnefort <vdonnefort@google.com> wrote:

> Add load/unload callback used for each admitted page in the ring-buffer.
> This will be later useful for the pKVM hypervisor which uses a different
> VA space and need to dynamically map/unmap the ring-buffer pages.
> 
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
> 
> diff --git a/include/linux/simple_ring_buffer.h b/include/linux/simple_ring_buffer.h
> index f324df2f875b..ecd0e988c699 100644
> --- a/include/linux/simple_ring_buffer.h
> +++ b/include/linux/simple_ring_buffer.h
> @@ -110,4 +110,11 @@ int simple_ring_buffer_reset(struct simple_rb_per_cpu *cpu_buffer);
>   */
>  int simple_ring_buffer_swap_reader_page(struct simple_rb_per_cpu *cpu_buffer);
>  
> +int __simple_ring_buffer_init(struct simple_rb_per_cpu *cpu_buffer,
> +			      struct simple_buffer_page *bpages,
> +			      const struct ring_buffer_desc *desc,
> +			      void *(*load_page)(unsigned long va),
> +			      void (*unload_page)(void *va));
> +void __simple_ring_buffer_unload(struct simple_rb_per_cpu *cpu_buffer,
> +				 void (*unload_page)(void *));

Underscored functions are for internally used functions and I rather not
have them for generic use (in include/linux).

Perhaps rename them as:

 int simple_ring_buffer_init_va()
 void simple_ring_buffer_init_va()

Or maybe "_mm()" would be better?

-- Steve