From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] tracing: Make the backup instance non-reusable
Date: Fri, 30 Jan 2026 18:01:35 +0900 [thread overview]
Message-ID: <20260130180135.7dd5b3731bf242d8d5e907c7@kernel.org> (raw)
In-Reply-To: <20260129145333.002815e1@gandalf.local.home>
On Thu, 29 Jan 2026 14:53:33 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 28 Jan 2026 09:09:56 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
>
> > @@ -9388,12 +9405,16 @@ static void
> > tracing_init_tracefs_percpu(struct trace_array *tr, long cpu)
> > {
> > struct dentry *d_percpu = tracing_dentry_percpu(tr, cpu);
> > + umode_t writable_mode = TRACE_MODE_WRITE;
> > struct dentry *d_cpu;
> > char cpu_dir[30]; /* 30 characters should be more than enough */
> >
> > if (!d_percpu)
> > return;
> >
> > + if (trace_array_is_readonly(tr))
> > + writable_mode = TRACE_MODE_READ;
>
> Hmm, writable_mode is set but not used?
Oops, good catch! I missed to update it.
Thanks!
>
> Looks like you missed an update.
>
> -- Steve
>
> > +
> > snprintf(cpu_dir, 30, "cpu%ld", cpu);
> > d_cpu = tracefs_create_dir(cpu_dir, d_percpu);
> > if (!d_cpu) {
> > @@ -9616,7 +9637,6 @@ struct dentry *trace_create_file(const char *name,
> > return ret;
> > }
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2026-01-30 9:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 0:09 [PATCH v5 0/4] tracing: Remove backup instance after read all Masami Hiramatsu (Google)
2026-01-28 0:09 ` [PATCH v5 1/4] tracing: Reset last_boot_info if ring buffer is reset Masami Hiramatsu (Google)
2026-01-28 0:09 ` [PATCH v5 2/4] tracing: Make the backup instance non-reusable Masami Hiramatsu (Google)
2026-01-29 19:53 ` Steven Rostedt
2026-01-30 9:01 ` Masami Hiramatsu [this message]
2026-01-29 20:07 ` Steven Rostedt
2026-01-30 9:20 ` Masami Hiramatsu
2026-01-30 15:21 ` Steven Rostedt
2026-01-28 0:10 ` [PATCH v5 3/4] tracing: Remove the backup instance automatically after read Masami Hiramatsu (Google)
2026-01-29 20:13 ` Steven Rostedt
2026-01-30 9:24 ` Masami Hiramatsu
2026-01-28 0:10 ` [PATCH v5 4/4] tracing/Documentation: Add a section about backup instance Masami Hiramatsu (Google)
2026-01-29 20:19 ` Steven Rostedt
2026-01-30 13:24 ` Masami Hiramatsu
2026-01-30 14:23 ` Steven Rostedt
2026-01-30 14:27 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260130180135.7dd5b3731bf242d8d5e907c7@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox