From: Steven Rostedt <rostedt@goodmis.org>
To: "jempty.liang" <imntjempty@163.com>
Cc: mhiramat@kernel.org, mark.rutland@arm.com,
mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Fix duration calculation bug (rettime - calltime) on ARM architecture
Date: Sat, 31 Jan 2026 07:56:06 -0500 [thread overview]
Message-ID: <20260131075606.2e4b7042@robin> (raw)
In-Reply-To: <586de639.2489.19c13895e08.Coremail.imntjempty@163.com>
On Sat, 31 Jan 2026 18:08:41 +0800 (CST)
"jempty.liang" <imntjempty@163.com> wrote:
> >
> >How is this unique to arm? I'm not able to duplicate this on x86, but the
> >code here is all generic code. What's different?
> >
>
> You're right, this bug is only reproducible on ARM.
You didn't answer my question. I understand that you said this only
impacts ARM. I'm asking you why does it only impact ARM? There's
nothing in this patch that is ARM specific? What is different about ARM
that makes this code have an issue where it doesn't have an issue with
x86?
>
> >You show what the wrong output is and the correct output, but you
> >don't mention what was the bug and how this fixes it. From the
> >change log, it looks like you just tried something and it worked,
> >but do not know why it worked.
> >
> >I'd like to know what the bug was and how this fixes it. It's not
> >obvious.
> >
>
> Before the patch, do_open_execat had an abnormal execution duration
> of 2757369004 us (over 1 second); the patch resolves this and
> restores the function to a normal duration range.
You still haven't answered my question. You are just telling me that
the patch fixes it but you do not tell me what in the code was wrong
and why the patch fixes it!
-- Steve
prev parent reply other threads:[~2026-01-31 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 1:57 [PATCH] tracing: Fix duration calculation bug (rettime - calltime) on ARM architecture jempty.liang
2026-01-30 20:55 ` Steven Rostedt
2026-01-31 10:11 ` jempty.liang
2026-01-31 12:56 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260131075606.2e4b7042@robin \
--to=rostedt@goodmis.org \
--cc=imntjempty@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox