From: Steven Rostedt <rostedt@goodmis.org>
To: Donglin Peng <dolinux.peng@gmail.com>
Cc: ast@kernel.org, mhiramat@kernel.org, andrii.nakryiko@gmail.com,
linux-kernel@vger.kernel.org,
Donglin Peng <pengdonglin@xiaomi.com>,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] tracing: resolve enum names for function arguments via BTF
Date: Mon, 2 Feb 2026 11:12:49 -0500 [thread overview]
Message-ID: <20260202111249.649ac338@gandalf.local.home> (raw)
In-Reply-To: <20260202111548.3555306-3-dolinux.peng@gmail.com>
On Mon, 2 Feb 2026 19:15:48 +0800
Donglin Peng <dolinux.peng@gmail.com> wrote:
> @@ -754,6 +755,14 @@ void print_function_args(struct trace_seq *s, unsigned long *args,
> break;
> case BTF_KIND_ENUM:
> trace_seq_printf(s, "%ld", arg);
> + for_each_enum(i, t, enump) {
> + if (arg == enump->val) {
> + trace_seq_printf(s, " [%s]",
> + btf_name_by_offset(btf,
> + enump->name_off));
> + break;
> + }
> + }
> break;
I have to ask; how big is that enum list?
Do we really want to do a linear search for every enum we come across?
What we could do is for the first time we hit an enum, create an array of
enums, sort them, and do a binary search from then on. This could be saved
in the tracing code itself (in kernel/trace/trace_btf.c), if BPF doesn't
care about it.
-- Steve
next prev parent reply other threads:[~2026-02-02 16:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260202111548.3555306-1-dolinux.peng@gmail.com>
2026-02-02 11:15 ` [PATCH 2/2] tracing: resolve enum names for function arguments via BTF Donglin Peng
2026-02-02 16:12 ` Steven Rostedt [this message]
2026-02-03 2:17 ` Donglin Peng
2026-02-03 13:50 ` Donglin Peng
2026-02-03 15:17 ` Steven Rostedt
2026-02-03 16:00 ` Alexei Starovoitov
2026-02-04 14:52 ` Donglin Peng
2026-02-05 9:21 ` Donglin Peng
2026-02-05 15:56 ` Alexei Starovoitov
2026-02-06 4:09 ` Donglin Peng
2026-02-06 16:04 ` Alexei Starovoitov
2026-02-08 13:08 ` Donglin Peng
2026-02-05 18:04 ` Steven Rostedt
2026-02-06 4:04 ` Donglin Peng
2026-02-08 13:07 ` Donglin Peng
2026-02-08 15:27 ` Steven Rostedt
2026-02-08 15:42 ` Donglin Peng
2026-02-08 16:47 ` Steven Rostedt
2026-02-04 14:16 ` Donglin Peng
2026-02-06 0:12 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202111249.649ac338@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=pengdonglin@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox