[PATCH] tracing: make tr->d_max_latency accessible without CONFIG_FSNOTIFY

[PATCH] tracing: make tr->d_max_latency accessible without CONFIG_FSNOTIFY

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

A recent change attempted to make the tracing_max_latency file visible
unconditionally, but this lead to a build failure:

kernel/trace/trace.c: In function 'trace_create_maxlat_file':
kernel/trace/trace.c:1543:13: error: 'struct trace_array' has no member named 'd_max_latency'; did you mean 'max_latency'?
 1543 |         tr->d_max_latency = trace_create_file("tracing_max_latency",
      |             ^~~~~~~~~~~~~

Make the corresponding change in the header file.

Fixes: ba73713da50e ("tracing: Clean up use of trace_create_maxlat_file()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/trace/trace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 3ebff304fe36..b8f3804586a0 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -351,8 +351,8 @@ struct trace_array {
 	unsigned int		snapshot;
 #ifdef CONFIG_TRACER_MAX_TRACE
 	unsigned long		max_latency;
-#ifdef CONFIG_FSNOTIFY
 	struct dentry		*d_max_latency;
+#ifdef CONFIG_FSNOTIFY
 	struct work_struct	fsnotify_work;
 	struct irq_work		fsnotify_irqwork;
 #endif /* CONFIG_FSNOTIFY */
-- 
2.39.5

Re: [PATCH] tracing: make tr->d_max_latency accessible without CONFIG_FSNOTIFY

[Steven Rostedt]

On Tue, 10 Feb 2026 15:13:06 +0100
Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> A recent change attempted to make the tracing_max_latency file visible
> unconditionally, but this lead to a build failure:
> 
> kernel/trace/trace.c: In function 'trace_create_maxlat_file':
> kernel/trace/trace.c:1543:13: error: 'struct trace_array' has no member named 'd_max_latency'; did you mean 'max_latency'?
>  1543 |         tr->d_max_latency = trace_create_file("tracing_max_latency",
>       |             ^~~~~~~~~~~~~
> 
> Make the corresponding change in the header file.
> 
> Fixes: ba73713da50e ("tracing: Clean up use of trace_create_maxlat_file()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Beat you to it ;-)

 https://lore.kernel.org/linux-trace-kernel/20260209194631.788bfc85@fedora/

-- Steve

Re: [PATCH] tracing: make tr->d_max_latency accessible without CONFIG_FSNOTIFY

[Steven Rostedt]

On Wed, 11 Feb 2026 12:51:52 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 10 Feb 2026 15:13:06 +0100
> Arnd Bergmann <arnd@kernel.org> wrote:
> 
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > A recent change attempted to make the tracing_max_latency file visible
> > unconditionally, but this lead to a build failure:
> > 
> > kernel/trace/trace.c: In function 'trace_create_maxlat_file':
> > kernel/trace/trace.c:1543:13: error: 'struct trace_array' has no member named 'd_max_latency'; did you mean 'max_latency'?
> >  1543 |         tr->d_max_latency = trace_create_file("tracing_max_latency",
> >       |             ^~~~~~~~~~~~~
> > 
> > Make the corresponding change in the header file.
> > 
> > Fixes: ba73713da50e ("tracing: Clean up use of trace_create_maxlat_file()")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>  
> 
> Beat you to it ;-)
> 
>  https://lore.kernel.org/linux-trace-kernel/20260209194631.788bfc85@fedora/

In fact, our changes were so identical that patchwork set both my patch
and your patch to queued when I applied mine to linux-next!

  https://patchwork.kernel.org/project/linux-trace-kernel/patch/20260210141310.1605322-1-arnd@kernel.org/

-- Steve