From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ring-buffer: Record invalid buffer event
Date: Fri, 20 Feb 2026 14:59:02 -0500 [thread overview]
Message-ID: <20260220145902.33704c96@gandalf.local.home> (raw)
In-Reply-To: <177140968338.1537493.3298484599734677165.stgit@mhiramat.tok.corp.google.com>
On Wed, 18 Feb 2026 19:14:43 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Record an invalid buffer event on the invalidated sub buffer
> so that user can notice how much data is skipped.
>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
As I showed in patch 3, just mark it as having missed events. We could add
a pr_warn() that says the buffer was corrupted, but we don't need a
"invalid" event.
-- Steve
prev parent reply other threads:[~2026-02-20 19:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 10:14 [PATCH v2 0/4] ring-buffer: Making persistent ring buffers robust Masami Hiramatsu (Google)
2026-02-18 10:14 ` [PATCH v2 1/4] ring-buffer: Fix to check event length before using Masami Hiramatsu (Google)
2026-02-18 10:14 ` [PATCH v2 2/4] ring-buffer: Flush and stop persistent ring buffer on panic Masami Hiramatsu (Google)
2026-02-20 19:53 ` Steven Rostedt
2026-02-18 10:14 ` [PATCH v2 3/4] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer Masami Hiramatsu (Google)
2026-02-20 19:56 ` Steven Rostedt
2026-02-23 7:39 ` Masami Hiramatsu
2026-02-18 10:14 ` [PATCH v2 4/4] ring-buffer: Record invalid buffer event Masami Hiramatsu (Google)
2026-02-20 19:59 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220145902.33704c96@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox