public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wander Lairson Costa <wander@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Gabriele Monaco <gmonaco@redhat.com>,
	Nam Cao <namcao@linutronix.de>,
	Wander Lairson Costa <wander@redhat.com>,
	linux-trace-kernel@vger.kernel.org (open list:RUNTIME
	VERIFICATION (RV)), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 07/19] rv/rvgen: fix typos in automata and generator docstring and comments
Date: Mon, 23 Feb 2026 13:17:50 -0300	[thread overview]
Message-ID: <20260223162407.147003-8-wander@redhat.com> (raw)
In-Reply-To: <20260223162407.147003-1-wander@redhat.com>

Fix two typos in the Automata class documentation that have been
present since the initial implementation. Fix the class
docstring: "part it" instead of "parses it". Additionally, a
comment describing transition labels contained the misspelling
"lables" instead of "labels".

Fix a typo in the comment describing the insertion of the initial
state into the states list: "bein og" should be "beginning of".

Fix typo in the module docstring: "Abtract" should be "Abstract".

Fix several occurrences of "automata" where it should be the singular
form "automaton".

Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>
---
 tools/verification/rvgen/rvgen/automata.py  | 8 ++++----
 tools/verification/rvgen/rvgen/dot2c.py     | 2 +-
 tools/verification/rvgen/rvgen/dot2k.py     | 4 ++--
 tools/verification/rvgen/rvgen/generator.py | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/tools/verification/rvgen/rvgen/automata.py b/tools/verification/rvgen/rvgen/automata.py
index 10146b6061ed2..b25378e92b16d 100644
--- a/tools/verification/rvgen/rvgen/automata.py
+++ b/tools/verification/rvgen/rvgen/automata.py
@@ -3,7 +3,7 @@
 #
 # Copyright (C) 2019-2022 Red Hat, Inc. Daniel Bristot de Oliveira <bristot@kernel.org>
 #
-# Automata object: parse an automata in dot file digraph format into a python object
+# Automata class: parse an automaton in dot file digraph format into a python object
 #
 # For further information, see:
 #   Documentation/trace/rv/deterministic_automata.rst
@@ -33,7 +33,7 @@ class AutomataError(Exception):
     """
 
 class Automata:
-    """Automata class: Reads a dot file and part it as an automata.
+    """Automata class: Reads a dot file and parses it as an automaton.
 
     It supports both deterministic and hybrid automata.
 
@@ -153,7 +153,7 @@ class Automata:
         states = sorted(set(states))
         states.remove(initial_state)
 
-        # Insert the initial state at the bein og the states
+        # Insert the initial state at the beginning of the states
         states.insert(0, initial_state)
 
         if not has_final_states:
@@ -175,7 +175,7 @@ class Automata:
                 line = self.__dot_lines[cursor].split()
                 event = "".join(line[line.index("label") + 2:-1]).replace('"', '')
 
-                # when a transition has more than one lables, they are like this
+                # when a transition has more than one labels, they are like this
                 # "local_irq_enable\nhw_local_irq_enable_n"
                 # so split them.
 
diff --git a/tools/verification/rvgen/rvgen/dot2c.py b/tools/verification/rvgen/rvgen/dot2c.py
index fa44795adef46..9255cc2153a31 100644
--- a/tools/verification/rvgen/rvgen/dot2c.py
+++ b/tools/verification/rvgen/rvgen/dot2c.py
@@ -3,7 +3,7 @@
 #
 # Copyright (C) 2019-2022 Red Hat, Inc. Daniel Bristot de Oliveira <bristot@kernel.org>
 #
-# dot2c: parse an automata in dot file digraph format into a C
+# dot2c: parse an automaton in dot file digraph format into a C
 #
 # This program was written in the development of this paper:
 #  de Oliveira, D. B. and Cucinotta, T. and de Oliveira, R. S.
diff --git a/tools/verification/rvgen/rvgen/dot2k.py b/tools/verification/rvgen/rvgen/dot2k.py
index 47af9f104a829..aedc2a7799b32 100644
--- a/tools/verification/rvgen/rvgen/dot2k.py
+++ b/tools/verification/rvgen/rvgen/dot2k.py
@@ -167,14 +167,14 @@ class da2k(dot2k):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         if self.is_hybrid_automata():
-            raise AutomataError("Detected hybrid automata, use the 'ha' class")
+            raise AutomataError("Detected hybrid automaton, use the 'ha' class")
 
 class ha2k(dot2k):
     """Hybrid automata only"""
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
         if not self.is_hybrid_automata():
-            raise AutomataError("Detected deterministic automata, use the 'da' class")
+            raise AutomataError("Detected deterministic automaton, use the 'da' class")
         self.trace_h = self._read_template_file("trace_hybrid.h")
         self.__parse_constraints()
 
diff --git a/tools/verification/rvgen/rvgen/generator.py b/tools/verification/rvgen/rvgen/generator.py
index d932e96dd66d3..988ccdc27fa37 100644
--- a/tools/verification/rvgen/rvgen/generator.py
+++ b/tools/verification/rvgen/rvgen/generator.py
@@ -3,7 +3,7 @@
 #
 # Copyright (C) 2019-2022 Red Hat, Inc. Daniel Bristot de Oliveira <bristot@kernel.org>
 #
-# Abtract class for generating kernel runtime verification monitors from specification file
+# Abstract class for generating kernel runtime verification monitors from specification file
 
 import platform
 import os
-- 
2.53.0


  parent reply	other threads:[~2026-02-23 16:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 16:17 [PATCH v3 00/19] rv/rvgen: Robustness, modernization, and fixes Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 01/19] rv/rvgen: introduce AutomataError exception class Wander Lairson Costa
2026-02-24  9:32   ` Gabriele Monaco
2026-02-23 16:17 ` [PATCH v3 02/19] rv/rvgen: remove bare except clauses in generator Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 03/19] rv/rvgen: replace % string formatting with f-strings Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 04/19] rv/rvgen: replace __len__() calls with len() Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 05/19] rv/rvgen: remove unnecessary semicolons Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 06/19] rv/rvgen: use context managers for file operations Wander Lairson Costa
2026-02-23 16:17 ` Wander Lairson Costa [this message]
2026-02-24  9:37   ` [PATCH v3 07/19] rv/rvgen: fix typos in automata and generator docstring and comments Gabriele Monaco
2026-02-23 16:17 ` [PATCH v3 08/19] rv/rvgen: fix PEP 8 whitespace violations Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 09/19] rv/rvgen: fix DOT file validation logic error Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 10/19] rv/rvgen: use class constant for init marker Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 11/19] rv/rvgen: refactor automata.py to use iterator-based parsing Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 12/19] rv/rvgen: remove unused sys import from dot2c Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 13/19] rv/rvgen: remove unused __get_main_name method Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 14/19] rv/rvgen: make monitor arguments required in rvgen Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 15/19] rv/rvgen: fix isinstance check in Variable.expand() Wander Lairson Costa
2026-02-23 16:17 ` [PATCH v3 16/19] rv/rvgen: extract node marker string to class constant Wander Lairson Costa
2026-02-23 16:18 ` [PATCH v3 17/19] rv/rvgen: enforce presence of initial state Wander Lairson Costa
2026-02-23 16:18 ` [PATCH v3 18/19] rv/rvgen: fix unbound loop variable warning Wander Lairson Costa
2026-02-23 16:18 ` [PATCH v3 19/19] rv/rvgen: fix _fill_states() return type annotation Wander Lairson Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260223162407.147003-8-wander@redhat.com \
    --to=wander@redhat.com \
    --cc=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox