public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Qing Wang <wangqing7171@gmail.com>
To: syzbot+3b5dd2030fe08afdf65d@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	mathieu.desnoyers@efficios.com, mhiramat@kernel.org,
	rostedt@goodmis.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [trace?] WARNING in tracing_buffers_mmap_close (3)
Date: Thu, 26 Feb 2026 14:16:25 +0800	[thread overview]
Message-ID: <20260226061625.30751-1-wangqing7171@gmail.com> (raw)
In-Reply-To: <699fc6d3.a00a0220.21906d.0073.GAE@google.com>

#syz test

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 23de3719f495..c74ba9c8c98e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -8251,12 +8251,14 @@ static int tracing_buffers_mmap(struct file *filp, struct vm_area_struct *vma)
 		return ret;
 
 	ret = ring_buffer_map(iter->array_buffer->buffer, iter->cpu_file, vma);
-	if (ret)
+	if (ret) {
 		put_snapshot_map(iter->tr);
+		return ret;
+	}
 
 	vma->vm_ops = &tracing_buffers_vmops;
 
-	return ret;
+	return 0;
 }
 
 static const struct file_operations tracing_buffers_fops = {

  reply	other threads:[~2026-02-26  6:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  4:06 [syzbot] [trace?] WARNING in tracing_buffers_mmap_close (3) syzbot
2026-02-26  6:16 ` Qing Wang [this message]
2026-02-26  6:34   ` syzbot
2026-02-26  8:00 ` Qing Wang
2026-02-26  8:18   ` syzbot
2026-02-26  9:16 ` Qing Wang
2026-02-26  9:43   ` syzbot
2026-02-26 16:52   ` Steven Rostedt
2026-02-27  3:07     ` Qing Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260226061625.30751-1-wangqing7171@gmail.com \
    --to=wangqing7171@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=syzbot+3b5dd2030fe08afdf65d@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox