From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer
Date: Fri, 27 Feb 2026 08:29:58 +0900 [thread overview]
Message-ID: <20260227082958.8046dd1eb3e5f51f9fb77b28@kernel.org> (raw)
In-Reply-To: <20260226123655.4d2ca691@gandalf.local.home>
On Thu, 26 Feb 2026 12:36:55 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 26 Feb 2026 21:58:33 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>
> > > --- a/kernel/trace/ring_buffer.c
> > > +++ b/kernel/trace/ring_buffer.c
> > > @@ -2058,17 +2058,18 @@ static void rb_meta_validate_events(struct ring_buffer_per_cpu *cpu_buffer)
> > > if (ret < 0) {
> > > pr_info("Ring buffer meta [%d] invalid buffer page\n",
> > > cpu_buffer->cpu);
> >
> > This pr_info() should be removed too, because multiple pages
> > can be discarded.
>
> I wouldn't discard it, but instead add a "once" variable, where it shows it
> only once per CPU.
OK, let me update it.
Thanks!
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2026-02-26 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 6:52 [PATCH v4 0/3] ring-buffer: Making persistent ring buffers robust Masami Hiramatsu (Google)
2026-02-24 6:52 ` [PATCH v4 1/3] ring-buffer: Flush and stop persistent ring buffer on panic Masami Hiramatsu (Google)
2026-02-26 12:56 ` Masami Hiramatsu
2026-02-24 6:52 ` [PATCH v4 2/3] ring-buffer: Handle RB_MISSED_* flags on commit field correctly Masami Hiramatsu (Google)
2026-02-24 6:52 ` [PATCH v4 3/3] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer Masami Hiramatsu (Google)
2026-02-26 12:58 ` Masami Hiramatsu
2026-02-26 17:36 ` Steven Rostedt
2026-02-26 23:29 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227082958.8046dd1eb3e5f51f9fb77b28@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox