public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: AnishMulay <anishm7030@gmail.com>
Cc: viro@zeniv.linux.org.uk, mhiramat@kernel.org,
	mathieu.desnoyers@efficios.com,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracefs: Use dentry name snapshots instead of heap allocation
Date: Thu, 5 Mar 2026 16:52:31 -0500	[thread overview]
Message-ID: <20260305165231.67c2491d@gandalf.local.home> (raw)
In-Reply-To: <20260227211505.226643-1-anishm7030@gmail.com>

On Fri, 27 Feb 2026 16:15:05 -0500
AnishMulay <anishm7030@gmail.com> wrote:

> diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
> index 86ba8dc25aaef..ad322e8f9e2ad 100644
> --- a/fs/tracefs/inode.c
> +++ b/fs/tracefs/inode.c
> @@ -94,23 +94,14 @@ static struct tracefs_dir_ops {
>  	int (*rmdir)(const char *name);
>  } tracefs_ops __ro_after_init;
>  
> -static char *get_dname(struct dentry *dentry)
> -{
> -	return kmemdup_nul(dentry->d_name.name, dentry->d_name.len, GFP_KERNEL);
> -}
> -
>  static struct dentry *tracefs_syscall_mkdir(struct mnt_idmap *idmap,
>  					    struct inode *inode, struct dentry *dentry,
>  					    umode_t mode)

I can't even apply your patch as it appears you based it off of your local
branch that applied your previous version of the patch.

Please rebase it off of 7.0-rc2 and resend.

Thanks!

-- Steve

  parent reply	other threads:[~2026-03-05 21:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 19:44 [PATCH] tracefs: Simplify get_dname() with kmemdup_nul() AnishMulay
2026-02-27 20:18 ` Al Viro
2026-02-27 20:42   ` Steven Rostedt
2026-02-27 21:15     ` [PATCH v2] tracefs: Use dentry name snapshots instead of heap allocation AnishMulay
2026-03-05 18:12       ` Steven Rostedt
2026-03-05 21:52       ` Steven Rostedt [this message]
2026-03-06 20:04         ` [PATCH v3] " AnishMulay
2026-03-06 21:41           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260305165231.67c2491d@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=anishm7030@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox