From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/2] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer
Date: Sun, 8 Mar 2026 22:19:19 -0400 [thread overview]
Message-ID: <20260308221919.0ca52de6@robin> (raw)
In-Reply-To: <20260309095307.19a504c6880407bbf36b2cca@kernel.org>
On Mon, 9 Mar 2026 09:53:07 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > >
> > > I just realized that the origin didn't have correct grammar. But we
> > > still check the subbufs, why remove that comment?
> > >
> > > The original should have said:
> > >
> > > /* Do the meta buffers and subbufs have correct data? */
> >
> > I just removed the data check from this loop, so I think this should
> > focus on checking metadata itself. The data is checked later.
>
> Other checks in the loop are;
>
> - the entries in meta::buffers[] are inside correct range.
> - the duplicated entries in the meta::buffers[].
>
> So this only checks the meta::buffers[] (index array) now.
>
> /*
> * Ensure the meta::buffers have correct data. The data in each subbufs are
> * checked later in rb_meta_validate_events().
> */
>
> This will be more clear.
Sure.
-- Steve
next prev parent reply other threads:[~2026-03-09 2:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 14:26 [PATCH v7 0/2] ring-buffer: Making persistent ring buffers robust Masami Hiramatsu (Google)
2026-03-07 14:26 ` [PATCH v7 1/2] ring-buffer: Flush and stop persistent ring buffer on panic Masami Hiramatsu (Google)
2026-03-07 14:26 ` [PATCH v7 2/2] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer Masami Hiramatsu (Google)
2026-03-07 15:27 ` Steven Rostedt
2026-03-08 23:53 ` Masami Hiramatsu
2026-03-09 0:53 ` Masami Hiramatsu
2026-03-09 2:19 ` Steven Rostedt [this message]
2026-03-09 2:19 ` Steven Rostedt
2026-03-09 13:32 ` Masami Hiramatsu
2026-03-09 13:53 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308221919.0ca52de6@robin \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox