public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wander Lairson Costa <wander@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Tomas Glozar <tglozar@redhat.com>,
	Wander Lairson Costa <wander@redhat.com>,
	Ivan Pravdin <ipravdin.official@gmail.com>,
	Crystal Wood <crwood@redhat.com>,
	Costa Shulyupin <costa.shul@redhat.com>,
	John Kacur <jkacur@redhat.com>,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	Daniel Bristot de Oliveira <bristot@kernel.org>,
	Daniel Wagner <dwagner@suse.de>,
	linux-trace-kernel@vger.kernel.org (open list:Real-time Linux
	Analysis (RTLA) tools),
	linux-kernel@vger.kernel.org (open list:Real-time Linux Analysis
	(RTLA) tools),
	bpf@vger.kernel.org (open list:BPF
	[MISC]:Keyword:(?:\b|_)bpf(?:\b|_))
Subject: [PATCH v4 08/18] rtla/timerlat: Add bounds check for softirq vector
Date: Mon,  9 Mar 2026 16:46:21 -0300	[thread overview]
Message-ID: <20260309195040.1019085-9-wander@redhat.com> (raw)
In-Reply-To: <20260309195040.1019085-1-wander@redhat.com>

Add bounds checking when accessing the softirq_name array using the
vector value from kernel trace data. The vector field from the
osnoise:softirq_noise event is used directly as an array index without
validation, which could cause an out-of-bounds read if the kernel
provides an unexpected vector value.

The softirq_name array contains 10 elements corresponding to the
standard Linux softirq vectors. While the kernel should only provide
valid vector values in the range 0-9, defensive programming requires
validating untrusted input before using it as an array index. If an
out-of-range vector is encountered, display the word UNKNOWN instead
of attempting to read beyond the array bounds.

Signed-off-by: Wander Lairson Costa <wander@redhat.com>
---
 tools/tracing/rtla/src/timerlat_aa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/tracing/rtla/src/timerlat_aa.c b/tools/tracing/rtla/src/timerlat_aa.c
index 30ef56d644f9c..bc421637cc19b 100644
--- a/tools/tracing/rtla/src/timerlat_aa.c
+++ b/tools/tracing/rtla/src/timerlat_aa.c
@@ -417,8 +417,8 @@ static int timerlat_aa_softirq_handler(struct trace_seq *s, struct tep_record *r
 	taa_data->thread_softirq_sum += duration;
 
 	trace_seq_printf(taa_data->softirqs_seq, "  %24s:%-3llu %.*s %9.2f us\n",
-			 softirq_name[vector], vector,
-			 24, spaces,
+			 vector < ARRAY_SIZE(softirq_name) ? softirq_name[vector] : "UNKNOWN",
+			 vector, 24, spaces,
 			 ns_to_usf(duration));
 	return 0;
 }
-- 
2.53.0


  parent reply	other threads:[~2026-03-09 19:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 19:46 [PATCH v4 00/18] rtla: Robustness and code quality improvements Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 01/18] rtla: Exit on memory allocation failures during initialization Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 02/18] rtla: Use strdup() to simplify code Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 03/18] rtla/actions: Simplify argument parsing Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 04/18] rtla: Introduce common_threshold_handler() helper Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 05/18] rtla: Replace magic number with MAX_PATH Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 06/18] rtla: Simplify code by caching string lengths Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 07/18] rtla: Add strscpy() and replace strncpy() calls Wander Lairson Costa
2026-03-09 19:46 ` Wander Lairson Costa [this message]
2026-03-09 19:46 ` [PATCH v4 09/18] rtla: Handle pthread_create() failure properly Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 10/18] rtla: Add str_has_prefix() helper function Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 11/18] rtla: Use str_has_prefix() for prefix checks Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 12/18] rtla: Enforce exact match for time unit suffixes Wander Lairson Costa
2026-03-12 12:17   ` Tomas Glozar
2026-03-09 19:46 ` [PATCH v4 13/18] rtla: Use str_has_prefix() for option prefix check Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 14/18] rtla/timerlat: Simplify RTLA_NO_BPF environment variable check Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 15/18] rtla/trace: Fix write loop in trace_event_save_hist() Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 16/18] rtla/trace: Fix I/O handling in save_trace_to_file() Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 17/18] rtla/utils: Fix resource leak in set_comm_sched_attr() Wander Lairson Costa
2026-03-09 19:46 ` [PATCH v4 18/18] rtla/utils: Fix loop condition in PID validation Wander Lairson Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309195040.1019085-9-wander@redhat.com \
    --to=wander@redhat.com \
    --cc=bpf@vger.kernel.org \
    --cc=bristot@kernel.org \
    --cc=costa.shul@redhat.com \
    --cc=crwood@redhat.com \
    --cc=dwagner@suse.de \
    --cc=ipravdin.official@gmail.com \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglozar@redhat.com \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox