From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2C8E352FB0; Mon, 16 Mar 2026 07:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773647615; cv=none; b=Rz04aSXAXK90IrEECulIDX1NQFCorQCXUK5h4U3XzyosrKtUN4i49lUIZoEeDavPZ7tkrnESGIXIxIUoEMkK9gnLqD2HfnNaWeFIzbddstRGYlkuFjyXUMoW1KVmX6UMY8+mq7fEo6EQEb0OMcHi4HEd0KJbudB5SY05ECHF18U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773647615; c=relaxed/simple; bh=SFGHJzUAMaYciPoz4GXKPoVbGQUFoy7VI7htytp4fFE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=abHoe2Af/i/QSslQFclN2t+Ryzcw7Tu1sf94MHWv/C4KAwFzPuF2+jAWE7CJGkOga9MsCQVdUy5sFcSanxuxOvYU0Dg8cFE3yUFrCx9yC+rlO/lp8UsO1NBlN3JPyxMypNPoOrr2kp4BcuO/092r25BwYByAAY4b1lvokJ63D1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EBjUXNvZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EBjUXNvZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFC14C19421; Mon, 16 Mar 2026 07:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773647614; bh=SFGHJzUAMaYciPoz4GXKPoVbGQUFoy7VI7htytp4fFE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EBjUXNvZPuBAsmaRBz2Jh4gJQ9yrMPp40i0RAGSuoTHnynpfPBLpbfZl24tWG7XFz MklIQVWEJeQ/yi1ZnGLlJUljfxLNmXjKLoKZ3lbU622zKAsyJm8jfifUxxJUNJaNmB 6hm+/97yiCw0icX5lp8tvVivnnTT8F8BnNmBRDN1+lXxZDzhbAxHGhGzHPWu51D2Tt oJO5LWTTVHxM9qe5JhvQVxKjWe6aMkAGWiZus6ReAUSQT1ahvo6oGRONvGXe5YgeD6 H7KC3QB8TujuZAuqE/+cjv//loQl74ouM7EozdZb9qWpUzdcKrAAsntaa5n2+xcm+I +3Cl64zn/VLTQ== From: Jiri Olsa To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , Menglong Dong , Steven Rostedt Subject: [PATCHv3 bpf-next 10/24] bpf: Add support for tracing_multi link cookies Date: Mon, 16 Mar 2026 08:51:24 +0100 Message-ID: <20260316075138.465430-11-jolsa@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260316075138.465430-1-jolsa@kernel.org> References: <20260316075138.465430-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support to specify cookies for tracing_multi link. Cookies are provided in array where each value is paired with provided BTF ID value with the same array index. Such cookie can be retrieved by bpf program with bpf_get_attach_cookie helper call. Signed-off-by: Jiri Olsa --- include/linux/bpf.h | 1 + include/uapi/linux/bpf.h | 1 + kernel/bpf/trampoline.c | 1 + kernel/trace/bpf_trace.c | 18 ++++++++++++++++++ tools/include/uapi/linux/bpf.h | 1 + 5 files changed, 22 insertions(+) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index f22b9400a915..a919143a8b35 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -1901,6 +1901,7 @@ struct bpf_tracing_multi_node { struct bpf_tracing_multi_link { struct bpf_link link; + u64 *cookies; int nodes_cnt; struct bpf_tracing_multi_node nodes[] __counted_by(nodes_cnt); }; diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 7f5c51f27a36..e28722ddeb5b 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -1866,6 +1866,7 @@ union bpf_attr { } cgroup; struct { __aligned_u64 ids; + __aligned_u64 cookies; __u32 cnt; } tracing_multi; }; diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c index 9331cca8c0b4..c0450fb16bd4 100644 --- a/kernel/bpf/trampoline.c +++ b/kernel/bpf/trampoline.c @@ -1579,6 +1579,7 @@ int bpf_trampoline_multi_attach(struct bpf_prog *prog, u32 *ids, mnode = &link->nodes[i]; mnode->trampoline = tr; mnode->node.link = &link->link; + mnode->node.cookie = link->cookies ? link->cookies[i] : 0; } trampoline_lock_all(); diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 4a92d47d1eaf..5e3ff9ffc0ab 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -3612,6 +3612,7 @@ static void bpf_tracing_multi_link_dealloc(struct bpf_link *link) struct bpf_tracing_multi_link *tr_link = container_of(link, struct bpf_tracing_multi_link, link); + kvfree(tr_link->cookies); kvfree(tr_link); } @@ -3625,6 +3626,8 @@ int bpf_tracing_multi_attach(struct bpf_prog *prog, const union bpf_attr *attr) struct bpf_tracing_multi_link *link = NULL; struct bpf_link_primer link_primer; u32 cnt, *ids = NULL; + u64 __user *ucookies; + u64 *cookies = NULL; u32 __user *uids; int err; @@ -3647,6 +3650,19 @@ int bpf_tracing_multi_attach(struct bpf_prog *prog, const union bpf_attr *attr) goto error; } + ucookies = u64_to_user_ptr(attr->link_create.tracing_multi.cookies); + if (ucookies) { + cookies = kvmalloc_objs(*cookies, cnt); + if (!cookies) { + err = -ENOMEM; + goto error; + } + if (copy_from_user(cookies, ucookies, cnt * sizeof(*cookies))) { + err = -EFAULT; + goto error; + } + } + link = kvzalloc_flex(*link, nodes, cnt); if (!link) { err = -ENOMEM; @@ -3661,6 +3677,7 @@ int bpf_tracing_multi_attach(struct bpf_prog *prog, const union bpf_attr *attr) goto error; link->nodes_cnt = cnt; + link->cookies = cookies; err = bpf_trampoline_multi_attach(prog, ids, link); kvfree(ids); @@ -3671,6 +3688,7 @@ int bpf_tracing_multi_attach(struct bpf_prog *prog, const union bpf_attr *attr) return bpf_link_settle(&link_primer); error: + kvfree(cookies); kvfree(ids); kvfree(link); return err; diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 7f5c51f27a36..e28722ddeb5b 100644 --- a/tools/include/uapi/linux/bpf.h +++ b/tools/include/uapi/linux/bpf.h @@ -1866,6 +1866,7 @@ union bpf_attr { } cgroup; struct { __aligned_u64 ids; + __aligned_u64 cookies; __u32 cnt; } tracing_multi; }; -- 2.53.0