public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Kaiser <martin@kaiser.cx>
To: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH v2] tracing: fprobe: do not zero out unused fgraph_data
Date: Tue, 24 Mar 2026 09:47:08 +0100	[thread overview]
Message-ID: <20260324084804.375764-1-martin@kaiser.cx> (raw)
In-Reply-To: <20260323102020.239567-1-martin@kaiser.cx>

If fprobe_entry does not fill the allocated fgraph_data completely, the
unused part does not have to be zeroed.

fgraph_data is a short-lived part of the shadow stack. The preceding
length field allows locating the end regardless of the content.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
 - remove the memset instead of fixing the length

 kernel/trace/fprobe.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/trace/fprobe.c b/kernel/trace/fprobe.c
index dcadf1d23b8a..56d145017902 100644
--- a/kernel/trace/fprobe.c
+++ b/kernel/trace/fprobe.c
@@ -450,8 +450,6 @@ static int fprobe_fgraph_entry(struct ftrace_graph_ent *trace, struct fgraph_ops
 				used += FPROBE_HEADER_SIZE_IN_LONG + size_words;
 		}
 	}
-	if (used < reserved_words)
-		memset(fgraph_data + used, 0, reserved_words - used);
 
 	/* If any exit_handler is set, data must be used. */
 	return used != 0;
-- 
2.43.7


  parent reply	other threads:[~2026-03-24  8:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 10:19 [PATCH] tracing: fprobe: fix the length of unused fgraph_data Martin Kaiser
2026-03-23 12:06 ` Masami Hiramatsu
2026-03-23 14:48 ` Steven Rostedt
2026-03-24  0:34   ` Masami Hiramatsu
2026-03-24  8:05     ` Martin Kaiser
2026-03-24 15:39       ` Masami Hiramatsu
2026-03-24  8:47 ` Martin Kaiser [this message]
2026-03-24 12:39   ` [PATCH v2] tracing: fprobe: do not zero out " Steven Rostedt
2026-03-24 15:42     ` Masami Hiramatsu
2026-03-24 15:40   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260324084804.375764-1-martin@kaiser.cx \
    --to=martin@kaiser.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox