From: Varun R Mallya <varunrmallya@gmail.com>
To: bpf@vger.kernel.org, leon.hwang@linux.dev, memxor@gmail.com,
jolsa@kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, yonghong.song@linux.dev,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, varunrmallya@gmail.com
Subject: [PATCH bpf-next v4 0/2] Reject sleepable kprobe_multi programs at attach time
Date: Thu, 9 Apr 2026 00:05:47 +0530 [thread overview]
Message-ID: <20260408183549.92990-1-varunrmallya@gmail.com> (raw)
These patches fix an issue where sleepable kprobe_multi programs
were allowed to attach, leading to "sleeping function called from invalid
context" splats.
Because kprobe.multi programs run in atomic/RCU context, they cannot
sleep. However, `bpf_kprobe_multi_link_attach()` previously lacked
validation for the `prog->sleepable` flag. This allowed sleepable
helpers, such as `bpf_copy_from_user()`, to be invoked from an invalid
non-sleepable context.
This series addresses the issue by:
1. Rejecting sleepable kprobe_multi programs early in
`bpf_kprobe_multi_link_attach()` by returning -EINVAL.
2. Adding selftests to explicitly verify that attaching a sleepable
kprobe_multi program is rejected by the kernel.
P.S: The first of these two commits has been applied to the bpf tree.
Changes:
v1->v2:
- v1: https://lore.kernel.org/bpf/20260401134921.362148-1-varunrmallya@gmail.com/
- Defective selftest added
v2->v3:
- v2: https://lore.kernel.org/bpf/CAP01T74YgnKop-dgwBToOcfg4_D44t1wUBopFYPMquirCmaLfg@mail.gmail.com/
- Selftest separated from change into different commit.
v3->v4:
- v3: https://lore.kernel.org/bpf/20260401191126.440683-1-varunrmallya@gmail.com/
- Selftest moved to test_attach_api_fails.
- Changed attachment symbol to bpf_fentry_test1 for stability.
- Changes suggested by Leon implemented.
Varun R Mallya (2):
bpf: Reject sleepable kprobe_multi programs at attach time
selftests/bpf: Add test to ensure kprobe_multi is not sleepable
kernel/trace/bpf_trace.c | 4 +
.../bpf/prog_tests/kprobe_multi_test.c | 78 ++++++++++++++++++-
.../bpf/progs/kprobe_multi_sleepable.c | 25 ++++++
3 files changed, 106 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/selftests/bpf/progs/kprobe_multi_sleepable.c
--
2.53.0
next reply other threads:[~2026-04-08 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 18:35 Varun R Mallya [this message]
2026-04-08 18:35 ` [PATCH bpf-next v4 1/2] bpf: Reject sleepable kprobe_multi programs at attach time Varun R Mallya
2026-04-08 18:35 ` [PATCH bpf-next v4 2/2] selftests/bpf: Add test to ensure kprobe_multi is not sleepable Varun R Mallya
2026-04-08 18:47 ` Varun R Mallya
2026-04-08 20:13 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408183549.92990-1-varunrmallya@gmail.com \
--to=varunrmallya@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=leon.hwang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=rostedt@goodmis.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox