Re: [PATCH v2] mm/page_alloc: trace PCP refills and PCP zone lock usage

SUVONOV BUNYOD
2026-04-29T03:32:02Z

Thanks for reviewing Steven,

>Why this change? It makes it much harder to understand.
>
>The above is not a normal macro. Ignore any checkpatch warnings about it.
>The proper way to do the TP_STRUCT__entry() is to make it just like a struct:
>
>struct {
> unsigned long pfn;
> unsigned int order;
> int migratetype;
>};
>
>Thus, the macro should be:
>
> TP_STRUCT__entry(
> __field( unsigned long, pfn )
> __field( unsigned int, order )
> __field( int, migratetype )
> ),

Yeah sorry for the formatting issue, will fix in v3. Any other concerns?
What do you think about the introduction of those tracepoints themselves?

-- Bunyod