public inbox for linux-trace-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Qian-Yu Lin <tiffany019230@gmail.com>
Cc: mhiramat@kernel.org, david.laight.linux@gmail.com,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] trace_printk: replace _______STR with __UNIQUE_ID(STR)
Date: Fri, 1 May 2026 12:21:06 -0400	[thread overview]
Message-ID: <20260501122106.2c2076e0@gandalf.local.home> (raw)
In-Reply-To: <afTSLgFwpYW1py36@nova>

On Sat, 2 May 2026 00:17:50 +0800
Qian-Yu Lin <tiffany019230@gmail.com> wrote:

> Yes, I verified it with the preprocessor output. I created a minimal
> test file:
> 
> // kernel/trace/test_trace_printk.c
> #include <linux/trace_printk.h>
> 
> void test(void) {
>     trace_printk("no args\n");
>     trace_printk("with arg %d\n", 42);
> }
> 
> Then ran make kernel/trace/test_trace_printk.i.
> 
> The no-args case has sizeof((char[]){"()"}) which is 3, so 3 > 3 is
> false and it falls through to trace_bputs/trace_puts.
> 
> The args case has sizeof((char[]){"(42)"}) which is 5, so 5 > 3 is
> true and it goes to trace_bprintk/trace_printk with the argument
> 42 correctly passed through.

Thanks. When I test, I do the same but just compile down to an object file
and run objdump and look at which functions were called.

-- Steve

  reply	other threads:[~2026-05-01 16:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 16:57 [PATCH] trace_printk: replace _______STR with __UNIQUE_ID(STR) Qian-Yu Lin
2026-04-29 17:42 ` Steven Rostedt
2026-04-29 21:47   ` David Laight
2026-05-01 14:51     ` Qian-Yu Lin
2026-05-01 14:40   ` Qian-Yu Lin
2026-05-01 15:19     ` Steven Rostedt
2026-05-01 16:17       ` Qian-Yu Lin
2026-05-01 16:21         ` Steven Rostedt [this message]
2026-05-01 21:13     ` David Laight
2026-05-02  7:37       ` Qian-Yu Lin
2026-05-01 16:28 ` [PATCH v2] trace_printk: replace ___STR with compound literal Qian-Yu Lin
2026-05-02  7:55 ` [PATCH v3] trace_printk: remove local variable for argument detection Qian-Yu Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260501122106.2c2076e0@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=david.laight.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=tiffany019230@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox