From: Steven Rostedt <rostedt@goodmis.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: Pengpeng Hou <pengpeng@iscas.ac.cn>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] tracing: Bound synthetic-field strings with seq_buf
Date: Fri, 1 May 2026 13:26:44 -0400 [thread overview]
Message-ID: <20260501132644.6d8424fa@gandalf.local.home> (raw)
In-Reply-To: <097ea2386bfea803f7c33d915f6990b6338e7821.camel@kernel.org>
On Fri, 01 May 2026 12:10:39 -0500
Tom Zanussi <zanussi@kernel.org> wrote:
> > + /* Terminate synthetic_name with a NUL. */
> > + seq_buf_str(&s);
> > +
>
> This doesn't hurt, but is it really needed? I think seq_buf_printf()
> already null-terminates.
Technically it does, but it's not guaranteed to do so. That is, only
seq_buf_str() defines terminating the string in the API.
-- Steve
prev parent reply other threads:[~2026-05-01 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 4:33 [PATCH v6] tracing: Bound synthetic-field strings with seq_buf Pengpeng Hou
2026-04-30 5:14 ` Masami Hiramatsu
2026-04-30 13:32 ` Steven Rostedt
2026-05-01 17:10 ` Tom Zanussi
2026-05-01 17:26 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260501132644.6d8424fa@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=pengpeng@iscas.ac.cn \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox