From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5382A402454; Thu, 7 May 2026 20:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778185373; cv=none; b=oQb5wkiFTp521C/6MzwmutdFjzFqRwNNuLpiYPpmUbyTV3zKrv1UiDJECtRDZESWDB03BOICfzMb2DLXP4XI3CrLNYVyJ01Wmhf/g9vAGXb1XSDskVAoz0Kgf9B4iXiNvGs2RHmxpzmqIAe6m8thA5PmjfLNk/h1/ooYpRy/vWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778185373; c=relaxed/simple; bh=1NB111VWMMIbtLLMaZhidTrmdjE0QUTjYTzPM4ECTnY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LO/HOcaJ1+dVVprxg4W7O/f0yaw+mSXdA3VfOMDd8C+xrWLtejR8bWhMUXDFNg2IOwA1TfLHS8sNdggrNt/sas/1fbza7CRiIECbk3tuwmL1AyRWjOHiDGMj6tToceI1oyVQDSey3Qnt3HiOd/jxoSBxU4yQpnzcs0wn9mi32pQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nD23O150; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nD23O150" Received: by smtp.kernel.org (Postfix) with ESMTPS id 30E20C2BCF6; Thu, 7 May 2026 20:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778185373; bh=1NB111VWMMIbtLLMaZhidTrmdjE0QUTjYTzPM4ECTnY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=nD23O150M5kxfo5P5NmOGYLjZ1wLSoVuj2fKNaT6dcOXKmDn98eMeXbf06onyK1w9 //K12jZviv6ykZKOu3HmsoV5E455JC3KCtY5hKPfflTmB3e5lHt+Ss7dA2cdPcosOz d9fBjtre4+ulurcD15ACbnpwYRZl0fZ5Fd4hhWQd6WLeakxfpnJrOUEt76yYLXWF56 LnXDzjQ1NFjQCZbABZFFeuYXJzDtcqBirFK2nOxlOZArnS9LwbIg1FEVVfCVoB1QDP QD7IQRIz8Sm6mBfS4gatvwK7czORbEgNKcnwsWCb8HOh45bbLTSsqhAYcsfdZLwn00 YJC5ZJFoc6izA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24881CD37AA; Thu, 7 May 2026 20:22:53 +0000 (UTC) From: Ackerley Tng via B4 Relay Date: Thu, 07 May 2026 13:22:58 -0700 Subject: [PATCH v6 39/43] KVM: selftests: Check fd/flags provided to mmap() when setting up memslot Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260507-gmem-inplace-conversion-v6-39-91ab5a8b19a4@google.com> References: <20260507-gmem-inplace-conversion-v6-0-91ab5a8b19a4@google.com> In-Reply-To: <20260507-gmem-inplace-conversion-v6-0-91ab5a8b19a4@google.com> To: aik@amd.com, andrew.jones@linux.dev, binbin.wu@linux.intel.com, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, ira.weiny@intel.com, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Jason Gunthorpe , Vlastimil Babka Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, Ackerley Tng X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778185365; l=1296; i=ackerleytng@google.com; s=20260225; h=from:subject:message-id; bh=hcETOw3sAakUfUaKNjQnUdIZ+346evieR+VBYLGswB4=; b=cIj661j8IDgWy+PWu4jCnPKM2SLywbk1kXdBd+D6Q62oSumO6qZFaetZYpSu9OcQrA6xB94ly 6pW1OA/sb4VDv5ZqJo7uX/yYjODzHvFiNDing5PYpFUp/jRBn9+zp9T X-Developer-Key: i=ackerleytng@google.com; a=ed25519; pk=sAZDYXdm6Iz8FHitpHeFlCMXwabodTm7p8/3/8xUxuU= X-Endpoint-Received: by B4 Relay for ackerleytng@google.com/20260225 with auth_id=649 X-Original-From: Ackerley Tng Reply-To: ackerleytng@google.com From: Sean Christopherson Check that a valid fd provided to mmap() must be accompanied by MAP_SHARED. With an invalid fd (usually used for anonymous mappings), there are no constraints on mmap() flags. Add this check to make sure that when a guest_memfd is used as region->fd, the flag provided to mmap() will include MAP_SHARED. Signed-off-by: Sean Christopherson [Rephrase assertion message.] Signed-off-by: Ackerley Tng --- tools/testing/selftests/kvm/lib/kvm_util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c index 8ff09e179ff5c..efad3e6b19f4b 100644 --- a/tools/testing/selftests/kvm/lib/kvm_util.c +++ b/tools/testing/selftests/kvm/lib/kvm_util.c @@ -1088,6 +1088,9 @@ void vm_mem_add(struct kvm_vm *vm, enum vm_mem_backing_src_type src_type, src_type == VM_MEM_SRC_SHARED_HUGETLB); } + TEST_ASSERT(region->fd == -1 || backing_src_is_shared(src_type), + "A valid fd provided to mmap() must be accompanied by MAP_SHARED."); + region->mmap_start = __kvm_mmap(region->mmap_size, PROT_READ | PROT_WRITE, vm_mem_backing_src_alias(src_type)->flag, region->fd, mmap_offset); -- 2.54.0.563.g4f69b47b94-goog