From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Ian Rogers <irogers@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v19 0/7] ring-buffer: Making persistent ring buffers robust
Date: Tue, 12 May 2026 09:54:31 +0900 [thread overview]
Message-ID: <20260512095431.a01161ece2acb7f48d7bd8c2@kernel.org> (raw)
In-Reply-To: <20260511122943.41e204bc@gandalf.local.home>
On Mon, 11 May 2026 12:29:43 -0400
Steven Rostedt <rostedt@kernel.org> wrote:
> On Thu, 7 May 2026 13:14:16 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>
> > > I'll test this some more, and make a proper patch.
> >
> > Ah, indeed. Thanks for fixing!
> >
> > BTW, shouldn't we unify common logic of those functions?
>
> Hmm, there's not much common between the two. One is a consuming read and
> the other is a non-consuming read that needs to test for a bunch of race
> conditions.
>
> If you see something that can be shared, I'm all for it.
Maybe we can introduce a common inline function to calculate
max_loop, or at least replacing "3" with a common macro.
Thank you,
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2026-05-12 0:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 3:28 [PATCH v19 0/7] ring-buffer: Making persistent ring buffers robust Masami Hiramatsu (Google)
2026-04-30 3:28 ` [PATCH v19 1/7] ring-buffer: Flush and stop persistent ring buffer on panic Masami Hiramatsu (Google)
2026-04-30 3:28 ` [PATCH v19 2/7] ring-buffer: Skip invalid sub-buffers when validating persistent ring buffer Masami Hiramatsu (Google)
2026-04-30 3:28 ` [PATCH v19 3/7] ring-buffer: Skip invalid sub-buffers when rewinding " Masami Hiramatsu (Google)
2026-04-30 3:28 ` [PATCH v19 4/7] ring-buffer: Add persistent ring buffer invalid-page inject test Masami Hiramatsu (Google)
2026-04-30 3:28 ` [PATCH v19 5/7] ring-buffer: Show commit numbers in buffer_meta file Masami Hiramatsu (Google)
2026-04-30 3:28 ` [PATCH v19 6/7] ring-buffer: Cleanup persistent ring buffer validation Masami Hiramatsu (Google)
2026-04-30 3:29 ` [PATCH v19 7/7] ring-buffer: Cleanup buffer_data_page related code Masami Hiramatsu (Google)
2026-05-02 19:23 ` [PATCH v19 0/7] ring-buffer: Making persistent ring buffers robust Steven Rostedt
2026-05-02 22:17 ` Steven Rostedt
2026-05-07 4:14 ` Masami Hiramatsu
2026-05-11 16:29 ` Steven Rostedt
2026-05-12 0:54 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512095431.a01161ece2acb7f48d7bd8c2@kernel.org \
--to=mhiramat@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=irogers@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox