From: Rosen Penev <rosenp@gmail.com>
To: linux-trace-kernel@vger.kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org (open list:FUNCTION HOOKS (FTRACE))
Subject: [PATCH] ftrace: Use flexible array for hash buckets
Date: Wed, 20 May 2026 15:00:30 -0700 [thread overview]
Message-ID: <20260520220030.16887-1-rosenp@gmail.com> (raw)
Store ftrace hash buckets in the ftrace_hash allocation instead of
allocating the bucket array separately.
This keeps the bucket storage tied to the hash lifetime and simplifies
the allocation and cleanup paths.
Assisted-by: Codex:GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
kernel/trace/ftrace.c | 17 ++---------------
kernel/trace/trace.h | 2 +-
2 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index b2611de3f594..25a9dca290dd 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -1082,10 +1082,7 @@ struct ftrace_func_probe {
* it all the time. These are in a read only section such that if
* anyone does try to modify it, it will cause an exception.
*/
-static const struct hlist_head empty_buckets[1];
-static const struct ftrace_hash empty_hash = {
- .buckets = (struct hlist_head *)empty_buckets,
-};
+static const struct ftrace_hash empty_hash = {};
#define EMPTY_HASH ((struct ftrace_hash *)&empty_hash)
struct ftrace_ops global_ops = {
@@ -1295,7 +1292,6 @@ void free_ftrace_hash(struct ftrace_hash *hash)
if (!hash || hash == EMPTY_HASH)
return;
ftrace_hash_clear(hash);
- kfree(hash->buckets);
kfree(hash);
}
@@ -1333,20 +1329,11 @@ EXPORT_SYMBOL_GPL(ftrace_free_filter);
struct ftrace_hash *alloc_ftrace_hash(int size_bits)
{
struct ftrace_hash *hash;
- int size;
- hash = kzalloc_obj(*hash);
+ hash = kzalloc_flex(*hash, buckets, BIT(size_bits));
if (!hash)
return NULL;
- size = 1 << size_bits;
- hash->buckets = kzalloc_objs(*hash->buckets, size);
-
- if (!hash->buckets) {
- kfree(hash);
- return NULL;
- }
-
hash->size_bits = size_bits;
return hash;
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 80fe152af1dd..5a3f81f17317 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -1000,10 +1000,10 @@ enum {
struct ftrace_hash {
unsigned long size_bits;
- struct hlist_head *buckets;
unsigned long count;
unsigned long flags;
struct rcu_head rcu;
+ struct hlist_head buckets[];
};
struct ftrace_func_entry *
--
2.54.0
next reply other threads:[~2026-05-20 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 22:00 Rosen Penev [this message]
2026-05-21 1:28 ` [PATCH] ftrace: Use flexible array for hash buckets Steven Rostedt
2026-05-21 1:39 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520220030.16887-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox