From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B85233F4DDB; Thu, 21 May 2026 14:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373590; cv=none; b=Z/CDP4P4tQzGw0IsHQHhTjf8eC5dDdk9vGFqx9YLYergRoPTm2UHgkCg1157Ahr0KQY7S8GFjd0uRt0oqTjr9xVpfz34t2xFMlwqpFU+mRTPABXWUPt6u84Qw/lJ70swkYAV7PMU0ByxaKJkfuWDpUe0/D6IbgIH8lpBdYyg4sM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373590; c=relaxed/simple; bh=8sU6dng2VpH5BI9Fg+BdbA7UQfT9/7ylu864IlNGg0I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QmQy+3jyZViiLvtXAa65a06cYvmiPztWdN47c+RmQyN2vOkX6WepZE/nzTCzkhuA2VjMjW9eJb7OucsWH30U03xR5fi82QtJvrcXu8oSKgERT8WqVAYgY9Xd2uFsimHDwx47Wp4rkqrJUczezkehtyvblHNGgiXV6NSZtty42gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=cxSEsK2R; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="cxSEsK2R" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L56Khr069859; Thu, 21 May 2026 14:25:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=ZOI+endUXTAW/hiF8 xST2Onr+K2NDqLcMTY3E9gHalc=; b=cxSEsK2Rq8pv0nfKEUhpLknSYTXA+4ddy V8+e4s4ccwzeYtjKbBF7YtBNtzaa8lkUrDsynV7JGU6oNX1O5MkysGgp8v2W/MyY 2qulRMUXTpo3b0DfG8et47Y+opqk9CJC7/o2OpGF3LkgYDBMYQq3McYSqkAvZK0A 9c/ArtQNA7k/rGp8pB5U13eczh3Cv1ggbpTsAs3JoKfQzUCDKgzBIGtoHoewvBvR F1GMVJwh3EtaoOwEIWlypg05LkHMDLGEB46klGIdAzER3LMjvL81xDFcnjQrIqu+ EFpNKohy1KkrA5nqJS7ew+7SZMCmnoXvXtDQjfw+NqUFL3il5Itnw== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e6h8myd9v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 May 2026 14:25:57 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64LEO5Oq002166; Thu, 21 May 2026 14:25:56 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4e754gmbhr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 May 2026 14:25:56 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64LEPqTC45678874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 May 2026 14:25:52 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B023520049; Thu, 21 May 2026 14:25:52 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5ABBA2004B; Thu, 21 May 2026 14:25:52 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 21 May 2026 14:25:52 +0000 (GMT) From: Jens Remus To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, Steven Rostedt , Josh Poimboeuf , Indu Bhagat , Peter Zijlstra , Dylan Hatch , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Mathieu Desnoyers , Kees Cook , Sam James Cc: Jens Remus , bpf@vger.kernel.org, linux-mm@kvack.org, Namhyung Kim , Andrii Nakryiko , "Jose E. Marchesi" , Beau Belgrave , Florian Weimer , "Carlos O'Donell" , Masami Hiramatsu , Jiri Olsa , Arnaldo Carvalho de Melo , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Heiko Carstens , Vasily Gorbik , Ilya Leoshkevich Subject: [PATCH v16 09/20] unwind_user/sframe: Add support for outermost frame indication Date: Thu, 21 May 2026 16:25:35 +0200 Message-ID: <20260521142546.3908498-10-jremus@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260521142546.3908498-1-jremus@linux.ibm.com> References: <20260521142546.3908498-1-jremus@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: 7rCW1Kl3JiSQvbDTjkeDjn_xdyYqbIvC X-Authority-Analysis: v=2.4 cv=GYMnWwXL c=1 sm=1 tr=0 ts=6a0f15f6 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=pGLkceISAAAA:8 a=VnNF1IyMAAAA:8 a=U72JrVpwKSe1qDC-WCIA:9 X-Proofpoint-ORIG-GUID: 6oi19XfIJtW8o8a5alhlhnDu9LdS-yia X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDE0MiBTYWx0ZWRfX+FQqoPmuqXsx spCH1rZ3/2BhMfree/aFtSJg3/02POcjFlCrrjiN0okatgPjd28Aeh3lymXLoDeWa+wtRSmOJcM I/EtAEa5ooi4R1zT4zKnIraBpiliFKoLGy/ADAq10WPQVulIhzdtF6nNG15bhdcoSk8b9+YLVQE Mw9OHusxDuB75oNGcBCOq5cHhmJ1f+VHBh/YhT4g4KLUC9FM7VtUtCkUkKSbQqY9tsl0ZSCKK7f xmkI0JOHIlFM2+4pDdULWxFDr2IwGa/FZU6EQotKYZh6+lagDGWe1fm5gfgpqxiROOzTrTXybLJ HUzvDUEc+hevIctj4eKTSAp2P1l6GFj8DuHsSm8xh2/4YLrSyPidA3VIG2cg5k3Qitn9nSaCcXG jGzkUPOpILjCHE+0QitaRHCBKjMS3jX7yYRgRc36dGgLUx9DjINpAvRtTcsgoWzSq/Mc0tGC9pw 6AOOqClSEssxylHmfSA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210142 SFrame may represent an undefined return address (RA) as SFrame FRE without any offsets as indication for an outermost frame. Reviewed-by: Indu Bhagat Signed-off-by: Jens Remus --- kernel/unwind/sframe.c | 15 ++++++++++++++- kernel/unwind/sframe.h | 1 + 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/kernel/unwind/sframe.c b/kernel/unwind/sframe.c index 2de29c836f6b..41ece3ca62a1 100644 --- a/kernel/unwind/sframe.c +++ b/kernel/unwind/sframe.c @@ -231,7 +231,7 @@ static __always_inline int __read_fre(struct sframe_section *sec, UNSAFE_GET_USER_INC(info, cur, 1, Efault); dataword_count = SFRAME_V3_FRE_DATAWORD_COUNT(info); dataword_size = dataword_size_enum_to_size(SFRAME_V3_FRE_DATAWORD_SIZE(info)); - if (!dataword_count || !dataword_size) + if (!dataword_size) return -EINVAL; fre_size = addr_size + 1 + (dataword_count * dataword_size); @@ -242,6 +242,17 @@ static __always_inline int __read_fre(struct sframe_section *sec, if (fde_type != SFRAME_FDE_TYPE_DEFAULT) return -EINVAL; + if (!dataword_count) { + /* + * A FRE without data words indicates RA undefined / + * outermost frame. + */ + cfa_off = 0; + ra_off = 0; + fp_off = 0; + goto done; + } + UNSAFE_GET_USER_INC(cfa_off, cur, dataword_size, Efault); dataword_count--; @@ -262,6 +273,7 @@ static __always_inline int __read_fre(struct sframe_section *sec, if (dataword_count) return -EINVAL; +done: fre->size = fre_size; fre->ip_off = ip_off; fre->cfa_off = cfa_off; @@ -328,6 +340,7 @@ static __always_inline int __find_fre(struct sframe_section *sec, frame->ra_off = fre->ra_off; frame->fp_off = fre->fp_off; frame->use_fp = SFRAME_V3_FRE_CFA_BASE_REG_ID(fre->info) == SFRAME_BASE_REG_FP; + frame->outermost = SFRAME_V3_FRE_RA_UNDEFINED_P(fre->info); return 0; } diff --git a/kernel/unwind/sframe.h b/kernel/unwind/sframe.h index fc2908e92c7b..ed111fd0d702 100644 --- a/kernel/unwind/sframe.h +++ b/kernel/unwind/sframe.h @@ -77,5 +77,6 @@ struct sframe_fda_v3 { #define SFRAME_V3_FRE_DATAWORD_COUNT(info) (((info) >> 1) & 0xf) #define SFRAME_V3_FRE_DATAWORD_SIZE(info) (((info) >> 5) & 0x3) #define SFRAME_V3_AARCH64_FRE_MANGLED_RA_P(info) (((info) >> 7) & 0x1) +#define SFRAME_V3_FRE_RA_UNDEFINED_P(info) (SFRAME_V3_FRE_DATAWORD_COUNT(info) == 0) #endif /* _SFRAME_H */ -- 2.51.0