Linux Trace Kernel
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Gabriele Monaco <gmonaco@redhat.com>,
	Nam Cao <namcao@linutronix.de>,
	linux-trace-kernel@vger.kernel.org
Cc: Wen Yang <wen.yang@linux.dev>
Subject: [PATCH v2 03/12] rv: Reset per-task DA monitors before releasing the slot
Date: Wed, 27 May 2026 08:23:03 +0200	[thread overview]
Message-ID: <20260527062313.39908-4-gmonaco@redhat.com> (raw)
In-Reply-To: <20260527062313.39908-1-gmonaco@redhat.com>

Per-task monitors use task_mon_slot to determine which slot in the array
to use for the monitor. During destruction, this slot is returned but
this is done before resetting the monitor. As a result, the monitor's
reset is in fact resetting a slot that is outside of the array
(RV_PER_TASK_MONITOR_INIT).

Release the slot only after the reset to avoid out-of-bound memory
access.

Fixes: f5587d1b6ec93 ("rv: Add Hybrid Automata monitor type")
Suggested-by: Wen Yang <wen.yang@linux.dev>
Reviewed-by: Wen Yang <wen.yang@linux.dev>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
 include/rv/da_monitor.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/rv/da_monitor.h b/include/rv/da_monitor.h
index 250888812125..0b7028df08fb 100644
--- a/include/rv/da_monitor.h
+++ b/include/rv/da_monitor.h
@@ -309,10 +309,11 @@ static inline void da_monitor_destroy(void)
 		WARN_ONCE(1, "Disabling a disabled monitor: " __stringify(MONITOR_NAME));
 		return;
 	}
-	rv_put_task_monitor_slot(task_mon_slot);
-	task_mon_slot = RV_PER_TASK_MONITOR_INIT;
 
 	da_monitor_reset_all();
+
+	rv_put_task_monitor_slot(task_mon_slot);
+	task_mon_slot = RV_PER_TASK_MONITOR_INIT;
 }
 
 #elif RV_MON_TYPE == RV_MON_PER_OBJ
-- 
2.54.0


  parent reply	other threads:[~2026-05-27  6:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  6:23 [PATCH v2 00/12] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-05-27  6:23 ` [PATCH v2 01/12] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-05-28  8:38   ` Nam Cao
2026-05-27  6:23 ` [PATCH v2 02/12] rv: Fix read_lock scope in per-task DA cleanup Gabriele Monaco
2026-05-28  8:43   ` Nam Cao
2026-05-27  6:23 ` Gabriele Monaco [this message]
2026-05-28  8:48   ` [PATCH v2 03/12] rv: Reset per-task DA monitors before releasing the slot Nam Cao
2026-05-27  6:23 ` [PATCH v2 04/12] rv: Prevent task migration while handling per-CPU events Gabriele Monaco
2026-05-28  8:56   ` Nam Cao
2026-05-27  6:23 ` [PATCH v2 05/12] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-05-28  8:59   ` Nam Cao
2026-05-27  6:23 ` [PATCH v2 06/12] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-05-28  9:01   ` Nam Cao
2026-05-27  6:23 ` [PATCH v2 07/12] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-05-28  9:09   ` Nam Cao
2026-05-27  6:23 ` [PATCH v2 08/12] rv: Ensure synchronous cleanup for HA monitors Gabriele Monaco
2026-05-27  6:23 ` [PATCH v2 09/12] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-05-27  6:23 ` [PATCH v2 10/12] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-05-27  6:23 ` [PATCH v2 11/12] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco
2026-05-27  6:23 ` [PATCH v2 12/12] verification/rvgen: Fix suffix strip in dot2k Gabriele Monaco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260527062313.39908-4-gmonaco@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=namcao@linutronix.de \
    --cc=rostedt@goodmis.org \
    --cc=wen.yang@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox