From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034083DE44D; Wed, 27 May 2026 16:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779898309; cv=none; b=DBnax0Nv5NR7XrADMP0vf822XEv0AKJagghOEDjnDnx027AgyAhzAoYqDLHWkoNUjzarQnaR02vIagmJgWk3oCf9iVMAtG13cmwvMJ9na4jGov1ZrzlKRbffGjceZI6T0VJXy11HIFz3x7bVy7LkVNTLXuLo37qX92Nehk8f1Kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779898309; c=relaxed/simple; bh=sdruol7Fs31BeuflQvxXxSyw8QHhUnwIx1LV0pXMp+c=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=ifnoOv14/Ao1TgZjrWVYPqUEGh43PJBqEdiz4uSZAEBmCsdkVx90IihEEYKZ6Nt6BZSHKbl1WSoU5CFmvF8C/qXb227hMTcBoEgjoKq6yzybclxbehzO0hKbJRjBHR5TfH9EJhNwkePdkfcn2Q7wWMpGO7RKMXvtxZm6ymB/HUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zgnp+18j; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zgnp+18j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D0441F00A3D; Wed, 27 May 2026 16:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779898307; bh=AR6lI/Goj8T5ut7ZS1IbeQktR4TdWge2vQqCWgAJvuE=; h=Date:From:To:Cc:Subject; b=Zgnp+18jM0sbLlMAS30+7jHyvbrSSFJa8rYVF9cM3y//lyXm0r4hQgt5GPr7TA2Cz PcVVlzt4Ao+y32lt88twnoml4IGfUasL5CAlQf2MZF0jHTVdYI8oMuZht8KvL0k6Tk eADERnLDx0+QwJUytADcD1HVGRfeI7in/BxHPwhjJxtaoTKvFB8Prmg1+WXhJBzP4x MTtSWPZMF8x7DUBNKTDztPiKZ3HV9NL7/caKFeklLNSwIjy5XSmZFMViqk8qJxQ81w kFnm9mDMRYpb7YwSVXUP0egSuNjLn5n0JVjxMLJgoAtgU4Zlt0e6aH41YudPKp/j4e AZvdUC8wa5VZw== Date: Wed, 27 May 2026 12:11:44 -0400 From: Steven Rostedt To: LKML , Linux trace kernel , linux-kbuild Cc: Andrew Morton , Masahiro Yamada , Masatake YAMATO , Peter Zijlstra , Geert Uytterhoeven , Michal Marek , Yang Bai , Stephen Boyd Subject: [PATCH v2] scripts: Have make TAGS not include structure members Message-ID: <20260527121144.08a1f676@fedora> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit From: Steven Rostedt It is really annoying when I use emacs TAGS to search for something like "dev_name" and have to go through 12 iterations before I find the function "dev_name". I really do not care about structures that include "dev_name" as one of its fields, and I'm sure pretty much all other developers do not care either. There's a "remove_structs" variable used by the scripts/tags.sh, which I'm guessing is suppose to remove these structures from the TAGS file, but it must do a poor job at it, as I'm always hitting structures when I want the actual declaration. Luckily, the etags program comes with an option "--no-members", which does exactly what I want, and I'm sure all other kernel developers want too. Create a new "no_members" variable and assign it to "--no-members" for the "TAGS" case and pass that to the etags program to remove structures. Signed-off-by: Steven Rostedt --- Changes since v1: https://lore.kernel.org/all/20131115093645.6dc03918@gandalf.local.home/ - Use a no_members variable instead of hard coding the --no-members into the etags call, as that can break some "tags" cases. (Michal Marek) - Rebase to the current decade. Yes, v1 is from 2013. I've been carrying this patch in my personal repos as a quilt entry where I would just push it when doing a "make TAGS". I also have the conversation still in my INBOX to remind me to send a v2. Talk about procrastination! It only took me 13 years to send the v2 :-p I'm still keeping the same Cc's. I wonder how many of them will be broken. :-/ scripts/tags.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/tags.sh b/scripts/tags.sh index 243373683f98..018588014eed 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -305,7 +305,7 @@ exuberant() emacs() { setup_regex emacs asm c - all_target_sources | xargs $1 -a "${regex[@]}" + all_target_sources | xargs $1 -a $no_members "${regex[@]}" setup_regex emacs kconfig all_kconfigs | xargs $1 -a "${regex[@]}" @@ -334,6 +334,7 @@ if [ "${ARCH}" = "um" ]; then fi remove_structs= +no_members= case "$1" in "cscope") docscope @@ -353,6 +354,7 @@ case "$1" in rm -f TAGS xtags etags remove_structs=y + no_members=--no-members ;; esac -- 2.53.0