From: Steven Rostedt <rostedt@goodmis.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Eva Kurchatova <eva.kurchatova@virtuozzo.com>,
mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com,
jpoimboe@kernel.org, samitolvanen@google.com
Subject: Re: [PATCH] tracing: fix CFI violation in probestub helper
Date: Sat, 30 May 2026 18:57:30 -0400 [thread overview]
Message-ID: <20260530185730.2928eb13@fedora> (raw)
In-Reply-To: <20260530221921.50d958cf@pumpkin>
On Sat, 30 May 2026 22:19:21 +0100
David Laight <david.laight.linux@gmail.com> wrote:
> > +/* \
> > + * The probestub is only used for tprobes and not referenced \
> > + * anywhere else. This causes objtool to think it's not called \
> > + * at all and will add it to the seal list which will remove \
> > + * the ENDBR causing issues if a tprobe is ever used. \
> > + */ \
>
> Isn't the sense of that all wrong?
The above is still correct. It just expresses what the probestub is
used for.
> Maybe:
> Annotate the protosub 'CFI_NOSEAL' to stop objtool requesting the
> kernel remove the ENDBR because the only references to the
> function are in the __tracepoint section that objtool doesn't scan.
I do agree that your version is a bit more concise.
Thanks,
-- Steve
prev parent reply other threads:[~2026-05-30 22:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 15:43 [PATCH] tracing: fix CFI violation in probestub helper Eva Kurchatova
2026-05-28 20:49 ` Steven Rostedt
2026-05-29 20:08 ` Peter Zijlstra
2026-05-29 23:51 ` Steven Rostedt
2026-05-30 15:52 ` Masami Hiramatsu
2026-05-30 21:19 ` David Laight
2026-05-30 22:57 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260530185730.2928eb13@fedora \
--to=rostedt@goodmis.org \
--cc=david.laight.linux@gmail.com \
--cc=eva.kurchatova@virtuozzo.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox