From: Peter Zijlstra <peterz@infradead.org>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] task_work: add tracepoints for task_work callbacks
Date: Wed, 10 Jun 2026 10:00:22 +0200 [thread overview]
Message-ID: <20260610080022.GD48970@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260610041408.2461637-1-imran.f.khan@oracle.com>
On Wed, Jun 10, 2026 at 12:14:08PM +0800, Imran Khan wrote:
> task_work tracepoints can be enabled by:
>
> echo 1 > /sys/kernel/tracing/events/task_work/enable
>
> and trace logs would look like:
>
> ... task_work_add_request: target_comm=ls target_pid=227 work=ffff95d20641a508 func=____fput notify=TWA_RESUME
> ... task_work_add_done: target_comm=ls target_pid=227 work=ffff95d20641a508 ret=0
> ... task_work_add_request: target_comm=ls target_pid=227 work=ffff95d20641a5c8 func=____fput notify=TWA_RESUME
> ... task_work_add_done: target_comm=ls target_pid=227 work=ffff95d20641a5c8 ret=0
> ... task_work_add_request: target_comm=ls target_pid=227 work=ffff95d20641a688 func=____fput notify=TWA_RESUME
> ... task_work_add_done: target_comm=ls target_pid=227 work=ffff95d20641a688 ret=0
> ... task_work_add_request: target_comm=ls target_pid=227 work=ffff95d20641a748 func=____fput notify=TWA_RESUME
> ... task_work_add_done: target_comm=ls target_pid=227 work=ffff95d20641a748 ret=0
> ... task_work_run_start: comm=ls pid=227 work=ffff95d20641a748 func=____fput
> ... task_work_run_end: comm=ls pid=227 work=ffff95d20641a748 func=____fput
> ... task_work_run_start: comm=ls pid=227 work=ffff95d20641a688 func=____fput
> ... task_work_run_end: comm=ls pid=227 work=ffff95d20641a688 func=____fput
> ... task_work_run_start: comm=ls pid=227 work=ffff95d20641a5c8 func=____fput
> ... task_work_run_end: comm=ls pid=227 work=ffff95d20641a5c8 func=____fput
> ... task_work_run_start: comm=ls pid=227 work=ffff95d20641a508 func=____fput
> ... task_work_run_end: comm=ls pid=227 work=ffff95d20641a508 func=____fput
>
> formatted as:
> target_comm=<comm of target task>
> target_pid=<pid of target task>
> work=<callback_head *>
> func=<callback_head->func>
> notify=<way to notify the target task>
> comm=<comm of current task executing func>
> pid=<pid of current task executing func>
And not a single justification for all this nonsense :-( So much ugly
and no gain...
prev parent reply other threads:[~2026-06-10 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 4:14 [PATCH] task_work: add tracepoints for task_work callbacks Imran Khan
2026-06-10 8:00 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610080022.GD48970@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=imran.f.khan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox