From: Steven Rostedt <rostedt@kernel.org>
To: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
Cc: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"bpf" <bpf@vger.kernel.org>,
"linux-trace-kernel" <linux-trace-kernel@vger.kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Menglong Dong" <menglong8.dong@gmail.com>
Subject: Re: [PATCHv7 bpf-next 03/29] ftrace: Add add_ftrace_hash_entry function
Date: Fri, 12 Jun 2026 10:44:15 -0400 [thread overview]
Message-ID: <20260612104415.0becd517@robin> (raw)
In-Reply-To: <DJ6EGJ8S87HP.2WOTGYK374XKI@gmail.com>
On Thu, 11 Jun 2026 10:35:11 -0700
"Alexei Starovoitov" <alexei.starovoitov@gmail.com> wrote:
> AI finds things to consider, but when they're considered and postponned
> to future it doesn't understand that and keep reporting the same thing
> every revision. So it might look like that patches are landing with
> outstanding AI complains, but this is not the case.
Well, if someone just asked me to give an ack then I would have. But I
have other things to work on. Especially since everything I do at the
moment is 100% hobby related. The chores my wife gives me now have
priority ;-)
I'll start a new job come Monday.
>
> btw since patches touch ftrace from time to time should we add your
> ftrace testsuite to bpf CI ?
That's actually a good idea.
> How automated is it?
Very. In fact it's public. Although it's been a few years since I
updated the git repos.
I have two qemu images (currently private, but I can update them and
share). Where one is a 32bit x86 image and the other is a 64bit image.
The 64bit image hostname is called tracetest and the 32bit image's
hostname is tracetest-32. Both with root password of test0000.
The tests loaded on the image is here:
https://github.com/rostedt/ftrace-tests
And the ktests I run are here:
https://github.com/rostedt/ftrace-ktests
I would run the ktest like;
ktest.pl -DPATCH_CHECKOUT:=<SHA/BRANCH> -DPATCH_START:=<first-commit> tracetest-64.conf
And in another window
ktest.pl -DPATCH_CHECKOUT:=<SHA/BRANCH> -DPATCH_START:=<first-commit> tracetest-32.conf
For example:
ktest.pl -DPATCH_CHECKOUT:=trace/ftrace/core -DPATCH_START:=b5d6d3f73d0bac4a7e3a061372f6da166fc6ee5c tracetest-64.conf
And that will run 40 tests (I added some more since my last push, so
github doesn't have 40) and build, boot, install, test on the qemu
64bit image. It starts out testing commits from
b5d6d3f73d0bac4a7e3a061372f6da166fc6ee5c and going through to
trace/ftrace/core. Note, the PATCH_START needs to be in the history of
the PATCH_CHECKOUT otherwise the test will fail.
If you want to run these, let me know and I can help with the setup.
It's what I gave Masami to test as well.
>
> >
> >>
> >> While at it, please review Mykyta's set:
> >> https://patchwork.kernel.org/user/todo/netdevbpf/?series=1096695
> >>
> >> It's also been pending for almost a month now.
> >
> > Have a better link? I just get a blank page as "TODO" is set to what I have.
>
> Ohh. I meant this set:
> https://lore.kernel.org/bpf/CAEf4BzZFjsEv3aLktwdCZF6EXoCL+eefX+6xa3XGrhBmfO1SqA@mail.gmail.com/
> where you said that you'll think more about it after pto.
I came back on Tuesday and have yet to catch up on all the email I
ignored while away :-p
> Would be great to land it now for this merge window, so we have
> discoverability right now and if better approach comes in the future
> we can adjust to it later.
>
I'll take a look at it.
-- Steve
next prev parent reply other threads:[~2026-06-12 14:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 11:05 [PATCHv7 bpf-next 00/29] bpf: tracing_multi link Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 01/29] ftrace: Add ftrace_hash_count function Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 02/29] ftrace: Add ftrace_hash_remove function Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 03/29] ftrace: Add add_ftrace_hash_entry function Jiri Olsa
2026-06-09 14:29 ` Steven Rostedt
2026-06-09 14:43 ` Kumar Kartikeya Dwivedi
2026-06-10 15:35 ` Steven Rostedt
2026-06-10 15:42 ` Alexei Starovoitov
2026-06-11 13:46 ` Steven Rostedt
2026-06-11 17:35 ` Alexei Starovoitov
2026-06-12 14:44 ` Steven Rostedt [this message]
2026-06-03 11:05 ` [PATCHv7 bpf-next 04/29] bpf: Use mutex lock pool for bpf trampolines Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 05/29] bpf: Add struct bpf_trampoline_ops object Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 06/29] bpf: Move trampoline image setup into bpf_trampoline_ops callbacks Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 07/29] bpf: Add bpf_trampoline_add/remove_prog functions Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 08/29] bpf: Add struct bpf_tramp_node object Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 09/29] bpf: Factor fsession link to use struct bpf_tramp_node Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 10/29] bpf: Add multi tracing attach types Jiri Olsa
2026-06-03 11:52 ` bot+bpf-ci
2026-06-03 11:05 ` [PATCHv7 bpf-next 11/29] bpf: Move sleepable verification code to btf_id_allow_sleepable Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 12/29] bpf: Add bpf_trampoline_multi_attach/detach functions Jiri Olsa
2026-06-03 11:52 ` bot+bpf-ci
2026-06-03 11:05 ` [PATCHv7 bpf-next 13/29] bpf: Add support for tracing multi link Jiri Olsa
2026-06-03 11:52 ` bot+bpf-ci
2026-06-04 8:00 ` Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 14/29] bpf: Add support for tracing_multi link cookies Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 15/29] bpf: Add support for tracing_multi link session Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 16/29] bpf: Add support for tracing_multi link fdinfo Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 17/29] libbpf: Add bpf_object_cleanup_btf function Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 18/29] libbpf: Add bpf_link_create support for tracing_multi link Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 19/29] libbpf: Add btf_type_is_traceable_func function Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 20/29] libbpf: Add support to create tracing multi link Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 21/29] selftests/bpf: Add tracing multi skel/pattern/ids attach tests Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 22/29] selftests/bpf: Add tracing multi skel/pattern/ids module " Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 23/29] selftests/bpf: Add tracing multi intersect tests Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 24/29] selftests/bpf: Add tracing multi cookies test Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 25/29] selftests/bpf: Add tracing multi session test Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 26/29] selftests/bpf: Add tracing multi attach fails test Jiri Olsa
2026-06-03 11:05 ` [PATCHv7 bpf-next 27/29] selftests/bpf: Add tracing multi verifier " Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612104415.0becd517@robin \
--to=rostedt@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=menglong8.dong@gmail.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox