From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA5AE401A13 for ; Wed, 17 Jun 2026 13:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781702317; cv=none; b=NRDjVzAiJq7ChMtrDH3wv799opkT8EQZwLuI1CLCyFgWDgy6prDqZ36nTZoGe2EBE4zCQs5Ww9DlvFweP678hZbjEUe21BAWPB6r/vJS2tZZbOqXSLkvwelOJ4/UkD/qz2qcAAgDAka3xigxEz8zEw85FBFjcSNMavf0tYnT4cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781702317; c=relaxed/simple; bh=l0Xn9kyxhrvC9seXbctAnu86Eq9wBNowthBDS3s0qmU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=sw3NCoEwoGvWObynhnkhawHVOtOrG95qZUINskkzG2xJ81BwGWyx1Z8fx7rZviFw6u408vCvIBbkor+Xlxf9TFNmcG9+jBR7VDXEkjc1kX6XrXSsAKAv0EivKes4BQ8qoY5u0s98Si0cTKelc3rUazvPTS4zozrHfvvGpgf7Ldo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=W+aGbUKU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W+aGbUKU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781702313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m5MlwK8H1RouRWnPpylGPOBGe2be1KDUgeDosuH7wfM=; b=W+aGbUKUeNGWU5SJjUSWW86I7kqSK8fizeH6Onn/PuElKZQ3yT9cIl1i9kKGWuDufQvX40 gZyNa9p3aoL1O8CrOVmlRBOqQgFiX++3RBJdbHHpS0dgwHi7edbtFUrCTXHsghdaUqX2HV p4aq1KFtbDUaBHCvwX9Tjca9PP/xFM4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-6E4jA7FVPJiwDMQEYScycQ-1; Wed, 17 Jun 2026 09:18:30 -0400 X-MC-Unique: 6E4jA7FVPJiwDMQEYScycQ-1 X-Mimecast-MFC-AGG-ID: 6E4jA7FVPJiwDMQEYScycQ_1781702309 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1E51619540D0; Wed, 17 Jun 2026 13:18:29 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.44.34.165]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B98A318005B3; Wed, 17 Jun 2026 13:18:25 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Tomas Glozar , Costa Shulyupin , Crystal Wood , John Kacur , Ivan Pravdin , Jonathan Corbet Subject: [RFC PATCH v2 2/4] rtla/osnoise: Record IPI count in osnoise top Date: Wed, 17 Jun 2026 15:17:57 +0200 Message-ID: <20260617131803.2988989-3-vschneid@redhat.com> In-Reply-To: <20260617131803.2988989-1-vschneid@redhat.com> References: <20260617131803.2988989-1-vschneid@redhat.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-MFC-PROC-ID: Vd_yxbOyVbu_iYxy00RV7qmCSLPWsh_EHBB1fJgSuQQ_1781702309 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Leverage the ipi_send_cpu and ipi_send_cpumask trace events to record the count of IPIs sent to monitored CPUs. These interferences are already accounted by the IRQ count, but this split gives a better overall picture. This uses the newly added -i cmdline option. Signed-off-by: Valentin Schneider --- tools/tracing/rtla/src/osnoise_top.c | 124 ++++++++++++++++++++++++++- 1 file changed, 123 insertions(+), 1 deletion(-) diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/osnoise_top.c index 512a6299cb018..5b462a3543b97 100644 --- a/tools/tracing/rtla/src/osnoise_top.c +++ b/tools/tracing/rtla/src/osnoise_top.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -25,6 +26,7 @@ struct osnoise_top_cpu { unsigned long long irq_count; unsigned long long softirq_count; unsigned long long thread_count; + unsigned long long ipi_count; int sum_cycles; }; @@ -70,6 +72,91 @@ static struct osnoise_top_data *osnoise_alloc_top(void) return NULL; } +static void account_ipi(struct osnoise_tool *tool, + unsigned long long src_cpu, unsigned long long dst_cpu) +{ + struct osnoise_top_cpu *cpu_data; + struct osnoise_top_data *data; + unsigned long long inc = 1; + + data = tool->data; + cpu_data = &data->cpu_data[dst_cpu]; + + update_sum(&cpu_data->ipi_count, &inc); +} + +/* + * osnoise_ipi_cpu_handler - this is the handler for single CPU IPI events. + */ +static int +osnoise_ipi_cpu_handler(struct trace_seq *s, struct tep_record *record, + struct tep_event *event, void *context) +{ + struct osnoise_tool *tool; + struct osnoise_params *params; + unsigned long long src_cpu, dst_cpu; + struct trace_instance *trace = context; + + tool = container_of(trace, struct osnoise_tool, trace); + params = to_osnoise_params(tool->params); + + src_cpu = record->cpu; + tep_get_field_val(s, event, "cpu", record, &dst_cpu, 1); + + if (CPU_ISSET(dst_cpu, ¶ms->common.monitored_cpus)) + account_ipi(tool, src_cpu, dst_cpu); + + return 0; +} + +static cpu_set_t cpumask_tmp_cpus; + +/* + * osnoise_ipi_cpumask_handler - this is the handler for broadcasted IPI events. + */ +static int +osnoise_ipi_cpumask_handler(struct trace_seq *s, struct tep_record *record, + struct tep_event *event, void *context) +{ + struct trace_instance *trace = context; + struct osnoise_tool *tool; + struct osnoise_params *params; + struct tep_format_field *field; + unsigned long long src_cpu; + cpu_set_t *event_cpus; + int len; + + tool = container_of(trace, struct osnoise_tool, trace); + params = to_osnoise_params(tool->params); + + src_cpu = record->cpu; + + field = tep_find_field(event, "cpumask"); + if (!field) + return 0; + + event_cpus = tep_get_field_raw(s, event, "cpumask", record, &len, 1); + if (!event_cpus) { + err_msg("Failed to get cpumask field\n"); + return 0; + } + + CPU_AND(&cpumask_tmp_cpus, event_cpus, ¶ms->common.monitored_cpus); + + /* + * Computing the mask weight is overkill but there is no leaner option + * provided by glibc, e.g cpumask_first() or somesuch. + */ + if (CPU_COUNT(&cpumask_tmp_cpus)) { + for (int cpu = 0; cpu < nr_cpus; cpu++) { + if (CPU_ISSET(cpu, &cpumask_tmp_cpus)) + account_ipi(tool, src_cpu, cpu); + } + } + + return 0; +} + /* * osnoise_top_handler - this is the handler for osnoise tracer events */ @@ -164,6 +251,8 @@ static void osnoise_top_header(struct osnoise_tool *top) goto eol; trace_seq_printf(s, " IRQ Softirq Thread"); + if (params->common.ipi) + trace_seq_printf(s, " IPI"); eol: if (pretty) @@ -218,7 +307,13 @@ static void osnoise_top_print(struct osnoise_tool *tool, int cpu) trace_seq_printf(s, "%12llu ", cpu_data->irq_count); trace_seq_printf(s, "%12llu ", cpu_data->softirq_count); - trace_seq_printf(s, "%12llu\n", cpu_data->thread_count); + trace_seq_printf(s, "%12llu", cpu_data->thread_count); + if (!params->common.ipi) { + trace_seq_printf(s, "\n"); + return; + } + + trace_seq_printf(s, " %12llu\n", cpu_data->ipi_count); } /* @@ -281,6 +376,7 @@ osnoise_top_apply_config(struct osnoise_tool *tool) struct osnoise_tool *osnoise_init_top(struct common_params *params) { struct osnoise_tool *tool; + int retval; tool = osnoise_init_tool("osnoise_top"); if (!tool) @@ -295,7 +391,33 @@ struct osnoise_tool *osnoise_init_top(struct common_params *params) tep_register_event_handler(tool->trace.tep, -1, "ftrace", "osnoise", osnoise_top_handler, NULL); + if (!params->ipi) + goto out; + + retval = tracefs_event_enable(tool->trace.inst, "ipi", "ipi_send_cpu"); + if (retval < 0 && !errno) { + err_msg("Could not find ipi_send_cpu event\n"); + goto out_err; + } + + retval = tracefs_event_enable(tool->trace.inst, "ipi", "ipi_send_cpumask"); + if (retval < 0 && !errno) { + err_msg("Could not find ipi_send_cpumask event\n"); + goto out_err; + } + + tep_register_event_handler(tool->trace.tep, -1, "ipi", "ipi_send_cpu", + osnoise_ipi_cpu_handler, NULL); + + tep_register_event_handler(tool->trace.tep, -1, "ipi", "ipi_send_cpumask", + osnoise_ipi_cpumask_handler, NULL); + +out: return tool; +out_err: + osnoise_free_top_tool(tool); + osnoise_destroy_tool(tool); + return NULL; } struct tool_ops osnoise_top_ops = { -- 2.54.0