Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@kernel.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Ogness <john.ogness@linutronix.de>,
	Thomas Gleixner <tglx@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Julia Lawall <julia.lawall@inria.fr>,
	Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH v3 2/2] tracing: Remove trace_printk.h from kernel.h
Date: Wed, 24 Jun 2026 10:32:25 -0400	[thread overview]
Message-ID: <20260624103225.77116713@fedora> (raw)
In-Reply-To: <20260624111152.75476a46@pumpkin>

On Wed, 24 Jun 2026 11:11:52 +0100
David Laight <david.laight.linux@gmail.com> wrote:

> That is all about changes to the file causing everything to be rebuilt,
> not the contents of the file slowing down builds.

I guess I should say it better. It causes more build time if that file
changes. That's what I meant. I update the wording to say:

   There have been complaints about trace_printk.h causing more build time
   for being in kernel.h it if changes. There is also an effort to clean up
   kernel.h to have it not include unneeded header files. Move trace_printk.h
   out of kernel.h and place it in the headers and C files that use it.
> 
> The part you are moving out of normal builds is just a few #defines.
> They won't have a significant effect on build times either.
> 
> So there is no point splitting out trace_controls.h.

That is a completely different reason. trace_printk.h is about
trace_printk() usage. The stuff split out into trace_controls.h have
nothing to do with trace_printk()s.

-- Steve


  reply	other threads:[~2026-06-24 14:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  8:18 [PATCH v3 0/2] tracing: Remove trace_printk.h from kernel.h Steven Rostedt
2026-06-24  8:18 ` [PATCH v3 1/2] tracing: Move non-trace_printk prototypes into trace_controls.h Steven Rostedt
2026-06-24  8:18 ` [PATCH v3 2/2] tracing: Remove trace_printk.h from kernel.h Steven Rostedt
2026-06-24 10:11   ` David Laight
2026-06-24 14:32     ` Steven Rostedt [this message]
2026-06-24 15:48       ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260624103225.77116713@fedora \
    --to=rostedt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=david.laight.linux@gmail.com \
    --cc=john.ogness@linutronix.de \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox