From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v13 04/11] perf/probe: Ignore comment lines in dynamic_events/kprobe_events file
Date: Tue, 30 Jun 2026 07:32:11 +0900 [thread overview]
Message-ID: <20260630073211.2a505d1f31e5fae1bf03b81a@kernel.org> (raw)
In-Reply-To: <178271361825.1176915.16095297120719039761.stgit@devnote2>
Hi Arnaldo, Namhyung,
I forgot to CC this. Can I pick this patch via linux-trace tree,
or would you pick this?
This is a part of typecast series [1] only for debugging.
[1] https://lore.kernel.org/all/178271361825.1176915.16095297120719039761.stgit@devnote2/
Thanks,
On Mon, 29 Jun 2026 15:13:38 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Since dynamic_events/kprobe_events files show the fetcharg debug
> information as comment lines, its reader needs to ignore it.
>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
> tools/perf/util/probe-file.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/probe-file.c b/tools/perf/util/probe-file.c
> index 4032572cbf55..4d12693a83b3 100644
> --- a/tools/perf/util/probe-file.c
> +++ b/tools/perf/util/probe-file.c
> @@ -197,6 +197,8 @@ struct strlist *probe_file__get_rawlist(int fd)
> idx = strlen(p) - 1;
> if (p[idx] == '\n')
> p[idx] = '\0';
> + if (buf[0] == '#')
> + continue;
> ret = strlist__add(sl, buf);
> if (ret < 0) {
> pr_debug("strlist__add failed (%d)\n", ret);
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2026-06-29 22:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 6:12 [PATCH v13 00/11] tracing/probes: Add more typecast features Masami Hiramatsu (Google)
2026-06-29 6:13 ` [PATCH v13 01/11] tracing/probes: Allow eprobe to use variable without $ prefix Masami Hiramatsu (Google)
2026-06-29 6:13 ` [PATCH v13 02/11] tracing/probes: Support dumping fetcharg program for debugging dynamic events Masami Hiramatsu (Google)
2026-06-29 6:13 ` [PATCH v13 03/11] tools/bootconfig: Ignore comment lines in dynamic_events/kprobe_events file Masami Hiramatsu (Google)
2026-06-29 6:13 ` [PATCH v13 04/11] perf/probe: " Masami Hiramatsu (Google)
2026-06-29 22:32 ` Masami Hiramatsu [this message]
2026-06-30 0:33 ` Namhyung Kim
2026-06-29 6:13 ` [PATCH v13 05/11] tracing/probes: Support typecast for various probe events Masami Hiramatsu (Google)
2026-06-29 6:13 ` [PATCH v13 06/11] tracing/probes: Support nested typecast Masami Hiramatsu (Google)
2026-06-29 6:14 ` [PATCH v13 07/11] tracing/probes: Type casting always involves nested calls Masami Hiramatsu (Google)
2026-06-29 6:14 ` [PATCH v13 08/11] tracing/probes: Support field specifier option for typecast Masami Hiramatsu (Google)
2026-06-29 6:14 ` [PATCH v13 09/11] tracing/probes: Add $current variable support Masami Hiramatsu (Google)
2026-06-29 6:14 ` [PATCH v13 10/11] tracing/probes: Add this_cpu_read() and this_cpu_ptr() dereference method to fetcharg Masami Hiramatsu (Google)
2026-06-29 6:14 ` [PATCH v13 11/11] tracing/probes: Add a new testcase for BTF typecasts Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630073211.2a505d1f31e5fae1bf03b81a@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox