Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: "Masami Hiramatsu" <mhiramat@kernel.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH 2/2] tracing: Keep pid and comm[] in the same structure
Date: Wed, 1 Jul 2026 06:38:22 -0400	[thread overview]
Message-ID: <20260701063822.3af87520@gandalf.local.home> (raw)
In-Reply-To: <20260701110407.31f7b6ca@pumpkin>

On Wed, 1 Jul 2026 11:04:07 +0100
David Laight <david.laight.linux@gmail.com> wrote:

> 
> I thought it was just used to do a pid->string lookup when you run 'cat trace'.
> But then I found the code that lets userspace read the table....
> I guess the latter is used by the userspace code that reads the raw trace buffer.

Yes, trace-cmd uses it.

> (I found some instructions that did it that way, the output was unparseable
> when tracing things that are happening on multiple cpu.)
> The userspace code could probably be given comm[] for all the running
> processes and those that exited while tracing_on() set.
> (I didn't see anything that would clear the table when the trace buffer
> was cleared.)

Well, that would break trace-cmd. As reading the raw buffers clears the
trace, and trace-cmd reads the saved_cmdlines file *after* it reads the
trace, as during the trace it gets populated.

-- Steve

  reply	other threads:[~2026-07-01 10:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26 21:23 [PATCH rfc 0/2] Improvements to ftrace comm[] handling David Laight
2026-06-26 21:23 ` [PATCH 1/2] tracing: Embed 'char comm[16]' in a structure David Laight
2026-06-29 20:26   ` Steven Rostedt
2026-06-30  9:26     ` David Laight
2026-06-26 21:23 ` [PATCH 2/2] tracing: Keep pid and comm[] in the same structure David Laight
2026-06-29 20:49   ` Steven Rostedt
2026-06-30 10:01     ` David Laight
2026-06-30 19:03       ` Steven Rostedt
2026-07-01 10:04         ` David Laight
2026-07-01 10:38           ` Steven Rostedt [this message]
2026-07-01 12:04             ` David Laight
2026-07-01 12:23               ` Steven Rostedt
2026-07-01 16:52                 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701063822.3af87520@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=david.laight.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mkoutny@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox