From: Steven Rostedt <rostedt@goodmis.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-trace-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: Cleanup event_enable_trigger_parse() by using __free()
Date: Thu, 2 Jul 2026 16:53:46 -0400 [thread overview]
Message-ID: <20260702165346.035f8eef@gandalf.local.home> (raw)
In-Reply-To: <79106214-b341-46ab-8810-a206ce8fad29@web.de>
On Thu, 2 Jul 2026 11:58:02 +0200
Markus Elfring <Markus.Elfring@web.de> wrote:
> …
> > +++ b/kernel/trace/trace_events_trigger.c
> > @@ -1739,7 +1739,7 @@ int event_enable_trigger_parse(struct event_command *cmd_ops,
> > char *glob, char *cmd, char *param_and_filter)
> > {
> > struct trace_event_file *event_enable_file;
> > - struct enable_trigger_data *enable_data;
> > + struct enable_trigger_data *enable_data __free(kfree) = NULL;
> …
>
> How do you think about to reduce the scope for this local variable?
>
No, it's fine as is.
-- Steve
next prev parent reply other threads:[~2026-07-02 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 21:48 [PATCH] tracing: Cleanup event_enable_trigger_parse() by using __free() Steven Rostedt
2026-07-01 22:41 ` Masami Hiramatsu
2026-07-02 9:58 ` Markus Elfring
2026-07-02 20:53 ` Steven Rostedt [this message]
2026-07-02 11:58 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702165346.035f8eef@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Markus.Elfring@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox