Re: [PATCH] tracing: make tracepoint_printk static as not exported

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 17 Jun 2026 11:58:22 +0100
Ben Dooks <ben.dooks@codethink.co.uk> wrote:

> The tracepoint_printk symbol is not exported, so make it
> static to remove the following sparse warning:
> 
> kernel/trace/trace.c:90:5: warning: symbol 'tracepoint_printk' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Thanks, this became only used by this file via commit dd293df6395a2
("tracing: Move trace sysctls into trace.c")

I may add a Fixes tag to that commit.

-- Steve


> ---
>  kernel/trace/trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 6eb4d3097a4d..4c3729c8d5e2 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -87,7 +87,7 @@ void __init disable_tracing_selftest(const char *reason)
>  
>  /* Pipe tracepoints to printk */
>  static struct trace_iterator *tracepoint_print_iter;
> -int tracepoint_printk;
> +static int tracepoint_printk;
>  static bool tracepoint_printk_stop_on_boot __initdata;
>  static bool traceoff_after_boot __initdata;
>  static DEFINE_STATIC_KEY_FALSE(tracepoint_printk_key);