From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Shuah Khan <shuah@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/tracing: Have trigger-hist-poll.tc use sched_process_exit
Date: Wed, 8 Jul 2026 16:35:39 -0400 [thread overview]
Message-ID: <20260708163539.1e1d845d@gandalf.local.home> (raw)
In-Reply-To: <20260708163436.058cc3df@gandalf.local.home>
On Wed, 8 Jul 2026 16:34:36 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> Currently trigger-hist-poll.tc uses sched_process_free to test the polling
> of the histogram file. The way it does that is to run sleep, then execute
> the poll.c code that polls on the sched_process_free for up to 4 seconds
> to test that when sleep triggers the sched_process_free trace event, it
> will update the histogram and wake the poll.c code up.
>
> The issue is that sched_process_free trace event is called by
> delayed_put_task_struct() which is called after a RCU grace period has
> ended. If CONFIG_RCU_LAZY is enabled, RCU callbacks are batched together
> and do not execute right away. This causes the delayed_put_task_struct()
> to be called after the poll.c function finishes and it will report an
> error that it did not wake up on the event. That's because the event
> didn't trigger during its wait time.
>
> Use sched_process_exit instead, which is called when a process exits and
> doesn't depend on RCU callbacks that may be delayed.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
I forgot to mention that I tested this with and without CONFIG_RCU_LAZY.
With that config disabled, the test passes. With it enabled, it always
fails.
-- Steve
next prev parent reply other threads:[~2026-07-08 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 20:34 [PATCH] selftests/tracing: Have trigger-hist-poll.tc use sched_process_exit Steven Rostedt
2026-07-08 20:35 ` Steven Rostedt [this message]
2026-07-08 20:37 ` Steven Rostedt
2026-07-09 4:58 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708163539.1e1d845d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox