From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Jeongho Choi <jh1012.choi@samsung.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
ji2yoon.jo@samsung.com, minki.jang@samsung.com,
hajun.sung@samsung.com
Subject: Re: [BUG] tracing: Too many tries to read user space
Date: Fri, 10 Jul 2026 07:46:05 -0400 [thread overview]
Message-ID: <20260710074605.33802554@gandalf.local.home> (raw)
In-Reply-To: <20260710122231.9bc9fae3dcfc72215f4a2dcd@kernel.org>
On Fri, 10 Jul 2026 12:22:31 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> However, this seems a bit strange that we only checks the CPU-wide context
> switching in the loop. Instead, can we introduce a per-cpu sequence counter
> to per-cpu buffer, and check it?
I originally tried this but found a situation that it fails:
tbuf->sequence = 0;
Task 1 Task 2
------ ------
tbuf->sequence++;
seq = tbuf->sequence; (seq = 1)
preempt_enable();
[schedule] ---------------------->
tbuf->sequence++;
seq = tbuf->sequence; (seq = 2);
preempt_enable();
copy_from_user(buffer);
<--------------------[schedule]
copy_from_user(buffer);
*** BUFFER NOW CORRUPTED ***
[schedule] ---------------------->
preempt_disable();
} while (tubf->sequence != seq); // tbuf->sequence == seq !!!!
This is why we use a CPU wide counter.
-- Steve
next prev parent reply other threads:[~2026-07-10 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260708123754epcas2p1f15cc305ddb09f97164491d750769ef7@epcas2p1.samsung.com>
2026-07-08 12:37 ` [BUG] tracing: Too many tries to read user space Jeongho Choi
2026-07-08 13:18 ` Steven Rostedt
2026-07-09 0:04 ` Masami Hiramatsu
2026-07-10 3:22 ` Masami Hiramatsu
2026-07-10 11:46 ` Steven Rostedt [this message]
2026-07-10 12:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710074605.33802554@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=hajun.sung@samsung.com \
--cc=jh1012.choi@samsung.com \
--cc=ji2yoon.jo@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=minki.jang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox