Linux Trace Kernel
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Chen Jun <chenjun102@huawei.com>
Cc: <mhiramat@kernel.org>, <mathieu.desnoyers@efficios.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-trace-kernel@vger.kernel.org>,
	"sashiko-bot@kernel.org" <sashiko-bot@kernel.org>,
	"sashiko-reviews@lists.linux.dev"
	<sashiko-reviews@lists.linux.dev>
Subject: Re: [PATCH] tracing: Add "within" filter for call-stack-based event filtering
Date: Fri, 10 Jul 2026 14:14:17 -0400	[thread overview]
Message-ID: <20260710141417.1fff0e13@gandalf.local.home> (raw)
In-Reply-To: <20260707112011.7ca6f721@gandalf.local.home>

On Tue, 7 Jul 2026 11:20:11 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > Does this goto need a preceding call to parse_error()?  Other error paths in
> > this function initialize the error state before jumping to err_free.
> > Without it, users might see an unhelpful generic error message instead of a
> > syntax error indicating that the glob operator isn't supported here.  
> 
> This is a legitimate issue.
> 
> Chen, can you send a v2 and add a proper error message here?

Hi Chen,

Do you plan on sending a v2?

Thanks,

-- Steve

      reply	other threads:[~2026-07-10 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 14:55 [PATCH] tracing: Add "within" filter for call-stack-based event filtering Chen Jun
2026-07-07 15:20 ` Steven Rostedt
2026-07-10 18:14   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260710141417.1fff0e13@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=chenjun102@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox