From: Steven Rostedt <rostedt@goodmis.org>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
Subject: Re: [PATCH v3 1/2] soc: qcom: geni-se: trace: Add trace event support for GENI SE registers dump
Date: Tue, 21 Jul 2026 16:52:20 -0400 [thread overview]
Message-ID: <20260721165220.63d56d38@gandalf.local.home> (raw)
In-Reply-To: <20260715-add-tracepoints-for-se-reg-dump-v3-1-0f787f93badd@oss.qualcomm.com>
On Wed, 15 Jul 2026 10:50:47 +0530
Praveen Talari <praveen.talari@oss.qualcomm.com> wrote:
> + TP_fast_assign(__assign_str(geni_se_name);
> + __entry->geni_se_m_cmd0 = readl(se->base + SE_GENI_M_CMD0);
> + __entry->geni_se_m_irq_status = readl(se->base + SE_GENI_M_IRQ_STATUS);
> + __entry->geni_se_s_cmd0 = readl(se->base + SE_GENI_S_CMD0);
> + __entry->geni_se_s_irq_status = readl(se->base + SE_GENI_S_IRQ_STATUS);
> + __entry->geni_se_status = readl(se->base + SE_GENI_STATUS);
> + __entry->geni_se_ios = readl(se->base + SE_GENI_IOS);
> + __entry->geni_se_m_cmd_ctrl = readl(se->base + SE_GENI_M_CMD_CTRL_REG);
> + __entry->geni_se_m_cmd_err = readl(se->base + M_CMD_ERR_STATUS);
> + __entry->geni_se_m_fw_err = readl(se->base + M_FW_ERR_STATUS);
> + __entry->geni_se_tx_fifo_status = readl(se->base + SE_GENI_TX_FIFO_STATUS);
> + __entry->geni_se_rx_fifo_status = readl(se->base + SE_GENI_RX_FIFO_STATUS);
> + __entry->geni_se_tx_watermark = readl(se->base + SE_GENI_TX_WATERMARK_REG);
> + __entry->geni_se_rx_watermark = readl(se->base + SE_GENI_RX_WATERMARK_REG);
> + __entry->geni_se_rx_watermark_rfr = readl(se->base + SE_GENI_RX_RFR_WATERMARK_REG);
> + __entry->geni_se_m_gp_length = readl(se->base + SE_GENI_M_GP_LENGTH);
> + __entry->geni_se_s_gp_length = readl(se->base + SE_GENI_S_GP_LENGTH);
> + __entry->geni_se_dma_tx_irq = readl(se->base + SE_DMA_TX_IRQ_STAT);
> + __entry->geni_se_dma_rx_irq = readl(se->base + SE_DMA_RX_IRQ_STAT);
> + __entry->geni_se_dma_tx_irq_en = readl(se->base + SE_DMA_TX_IRQ_EN);
> + __entry->geni_se_dma_rx_irq_en = readl(se->base + SE_DMA_RX_IRQ_EN);
> + __entry->geni_se_dma_rx_len = readl(se->base + SE_DMA_RX_LEN);
> + __entry->geni_se_dma_rx_len_in = readl(se->base + SE_DMA_RX_LEN_IN);
> + __entry->geni_se_dma_tx_len = readl(se->base + SE_DMA_TX_LEN);
> + __entry->geni_se_dma_tx_len_in = readl(se->base + SE_DMA_TX_LEN_IN);
> + __entry->geni_se_dma_tx_ptr_l = readl(se->base + SE_DMA_TX_PTR_L);
> + __entry->geni_se_dma_tx_ptr_h = readl(se->base + SE_DMA_TX_PTR_H);
> + __entry->geni_se_dma_rx_ptr_l = readl(se->base + SE_DMA_RX_PTR_L);
> + __entry->geni_se_dma_rx_ptr_h = readl(se->base + SE_DMA_RX_PTR_H);
> + __entry->geni_se_dma_tx_attr = readl(se->base + SE_DMA_TX_ATTR);
> + __entry->geni_se_dma_tx_max_burst = readl(se->base + SE_DMA_TX_MAX_BURST);
> + __entry->geni_se_dma_rx_attr = readl(se->base + SE_DMA_RX_ATTR);
> + __entry->geni_se_dma_rx_max_burst = readl(se->base + SE_DMA_RX_MAX_BURST);
> + __entry->geni_se_dma_if_en = readl(se->base + SE_DMA_IF_EN);
> + __entry->geni_se_dma_if_en_ro = readl(se->base + DMA_IF_EN_RO);
> + __entry->geni_se_dma_general_cfg = readl(se->base + DMA_GENERAL_CFG);
> + __entry->geni_se_dma_qsb_trans_cfg = readl(se->base + SE_DMA_QSB_TRANS_CFG);
> + __entry->geni_se_dma_dbg = readl(se->base + SE_DMA_DEBUG_REG0);
> + __entry->geni_se_m_irq_en = readl(se->base + SE_GENI_M_IRQ_EN);
> + __entry->geni_se_s_irq_en = readl(se->base + SE_GENI_S_IRQ_EN);
> + __entry->geni_se_gsi_event_en = readl(se->base + SE_GSI_EVENT_EN);
> + __entry->geni_se_irq_en = readl(se->base + SE_IRQ_EN);
> + __entry->geni_se_ser_m_clk_cfg = readl(se->base + GENI_SER_M_CLK_CFG);
> + __entry->geni_se_ser_s_clk_cfg = readl(se->base + GENI_SER_S_CLK_CFG);
> + __entry->geni_se_general_cfg = readl(se->base + GENI_GENERAL_CFG);
> + __entry->geni_se_output_ctrl = readl(se->base + GENI_OUTPUT_CTRL);
> + __entry->geni_se_clk_ctrl_ro = readl(se->base + GENI_CLK_CTRL_RO);
> + __entry->geni_se_fifo_if_disable = readl(se->base + GENI_IF_DISABLE_RO);
> + __entry->geni_se_fw_multilock_msa = readl(se->base + GENI_FW_MULTILOCK_MSA_RO);
> + __entry->geni_se_clk_sel = readl(se->base + SE_GENI_CLK_SEL);
> + ),
> +
I think this is the first time I've seen a trace event read IO directly.
Hmm, will this have any side effects?
If not, I have no problem with this:
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2026-07-21 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 5:20 [PATCH v3 0/2] Add trace event support for GENI SE registers dump Praveen Talari
2026-07-15 5:20 ` [PATCH v3 1/2] soc: qcom: geni-se: trace: " Praveen Talari
2026-07-21 20:52 ` Steven Rostedt [this message]
2026-07-15 5:20 ` [PATCH v3 2/2] spi: qcom-geni: add GENI SE registers trace event on error paths Praveen Talari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721165220.63d56d38@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox